Chromium Code Reviews| Index: third_party/snappy/BUILD.gn |
| diff --git a/third_party/snappy/BUILD.gn b/third_party/snappy/BUILD.gn |
| index 7eabb7b19e9bff0edc44f35c9edbb833b6ffffd6..9f7486744def302a1d9e29f1a1aaaa00431abc9e 100644 |
| --- a/third_party/snappy/BUILD.gn |
| +++ b/third_party/snappy/BUILD.gn |
| @@ -2,6 +2,8 @@ |
| # Use of this source code is governed by a BSD-style license that can be |
| # found in the LICENSE file. |
| +import("//testing/test.gni") |
| + |
| config("snappy_config") { |
| include_dirs = [ "src" ] |
| @@ -22,6 +24,10 @@ config("snappy_warnings") { |
| # https://code.google.com/p/snappy/issues/detail?id=96 |
| cflags = [ "-Wno-unused-function" ] |
| } |
| + |
| + if (is_win) { |
| + cflags = [ "/wd4018" ] # Signed/unsigned mismatch in comparison. |
|
jsbell
2017/03/10 15:57:36
+= ?
pwnall
2017/03/10 18:03:11
Done!
Thank you! Durr durr
|
| + } |
| } |
| static_library("snappy") { |
| @@ -44,9 +50,9 @@ static_library("snappy") { |
| ] |
| public_configs = [ ":snappy_config" ] |
| - if (is_win) { |
| - cflags = [ "/wd4018" ] # Signed/unsigned mismatch in comparison. |
| - } |
| + # Chromium doesn't use automake, but we generated config.h offline for all the |
| + # platforms that we build for. |
| + defines = [ "HAVE_CONFIG_H" ] |
| if (is_clang) { |
| # snappy-stubs-internal.h unapologetically has: using namespace std |