Chromium Code Reviews| Index: tracing/tracing/model/clock_sync_manager.html |
| diff --git a/tracing/tracing/model/clock_sync_manager.html b/tracing/tracing/model/clock_sync_manager.html |
| index 8498b49f5725a85ced51567b8f6b676d08cba11d..19cfa9b5c145c17c1ac8cd412070dc75153aba84 100644 |
| --- a/tracing/tracing/model/clock_sync_manager.html |
| +++ b/tracing/tracing/model/clock_sync_manager.html |
| @@ -25,15 +25,16 @@ tr.exportTo('tr.model', function() { |
| 'WIN_ROLLOVER_PROTECTED_TIME_GET_TIME', |
| WIN_QPC: 'WIN_QPC', |
| - // "Telemetry" isn't really a clock domain because Telemetry actually |
| - // can use one of several clock domains, just like Chrome. However, |
| - // because there's a chance that Telemetry is running off of the same |
| - // clock as Chrome (e.g. LINUX_CLOCK_MONOTONIC) but on a separate device |
| - // (i.e. on a host computer with Chrome running on an attached phone), |
| - // there's a chance that Chrome and Telemetry will erroneously get put into |
| + // "Telemetry" and "Systrace" aren't really clock domains because they |
|
charliea (OOO until 10-5)
2017/03/20 14:37:38
s/"Telemetry"/'TELEMETRY", same for "Systrace"
charliea (OOO until 10-5)
2017/03/21 19:47:23
P.S., wasn't this in the patch you already submitt
rnephew (Reviews Here)
2017/03/23 15:14:15
Done.
rnephew (Reviews Here)
2017/03/23 15:14:15
No this was not part of the BattOr tracing agent C
|
| + // actually can use one of several clock domains, just like Chrome. However, |
| + // because there's a chance that they are running off of the same clock as |
| + // Chrome (e.g. LINUX_CLOCK_MONOTONIC) but on a separate device (i.e. on a |
| + // a host computer with Chrome running on an attached phone), there's a |
| + // chance that Chrome and the controller will erroneously get put into |
| // the same clock domain. The solution for this is that clock domains should |
| // actually be some (unique_device_id, clock_id) tuple. For now, though, |
| // we'll hack around this by putting Telemetry into its own clock domain. |
| + SYSTRACE: 'SYSTRACE', |
| TELEMETRY: 'TELEMETRY' |
| }; |