Issue 27121003: Fix unexpected stack traces in test-cpu-profiler/JsNativeJsSample

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 27121003: Fix unexpected stack traces in test-cpu-profiler/JsNativeJsSample (Closed)

Created:
7 years, 2 months ago by yurys

Modified:
7 years, 2 months ago

Reviewers:
loislo, alph, Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix unexpected stack traces in test-cpu-profiler/JsNativeJsSample This is a follow-up fix for r17140 which makes sure that cpu profiler is started before profiled js functions are compiled so that the profiler gets information about "no frame" ranges along with add code events. BUG=v8:2933 R=jkummerow@chromium.org, loislo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17229

Patch Set 1 #

Patch Set 2 : Unskip cpu profiler tests #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -10 lines)			Patch
	M	test/cctest/cctest.status	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
	M	test/cctest/test-cpu-profiler.cc	View		4 chunks	+5 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

yurys

7 years, 2 months ago (2013-10-16 08:15:13 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r17229 (presubmit successful).

Expand Messages | Collapse Messages