Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Unified Diff: third_party/WebKit/Source/web/LocalFrameClientImpl.h

Issue 2712033002: Part 1 Of Renaming FrameLoaderClient to LocalFrameClient. (Closed)
Patch Set: Change all forward declarations of FrameLoaderClient to LocalFrameClient and fix call sites. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/LocalFrameClientImpl.h
diff --git a/third_party/WebKit/Source/web/FrameLoaderClientImpl.h b/third_party/WebKit/Source/web/LocalFrameClientImpl.h
similarity index 93%
copy from third_party/WebKit/Source/web/FrameLoaderClientImpl.h
copy to third_party/WebKit/Source/web/LocalFrameClientImpl.h
index 75ae5b30afd56a1d847803127ae214cc7239d068..bef391d3b82d160193977c6d96067ae733f8ca65 100644
--- a/third_party/WebKit/Source/web/FrameLoaderClientImpl.h
+++ b/third_party/WebKit/Source/web/LocalFrameClientImpl.h
@@ -29,14 +29,15 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-#ifndef FrameLoaderClientImpl_h
-#define FrameLoaderClientImpl_h
+#ifndef LocalFrameClientImpl_h
+#define LocalFrameClientImpl_h
-#include "core/loader/FrameLoaderClient.h"
+#include "core/frame/LocalFrameClient.h"
#include "platform/heap/Handle.h"
#include "platform/weborigin/KURL.h"
#include "public/platform/WebInsecureRequestPolicy.h"
#include "wtf/RefPtr.h"
+
#include <memory>
namespace blink {
@@ -44,17 +45,17 @@ namespace blink {
class WebDevToolsAgentImpl;
class WebLocalFrameImpl;
-class FrameLoaderClientImpl final : public FrameLoaderClient {
+class LocalFrameClientImpl final : public LocalFrameClient {
public:
- static FrameLoaderClientImpl* create(WebLocalFrameImpl*);
+ static LocalFrameClientImpl* create(WebLocalFrameImpl*);
- ~FrameLoaderClientImpl() override;
+ ~LocalFrameClientImpl() override;
DECLARE_VIRTUAL_TRACE();
WebLocalFrameImpl* webFrame() const { return m_webFrame.get(); }
- // FrameLoaderClient ----------------------------------------------
+ // LocalFrameClient ----------------------------------------------
void didCreateNewDocument() override;
// Notifies the WebView delegate that the JS window object has been cleared,
@@ -65,8 +66,7 @@ class FrameLoaderClientImpl final : public FrameLoaderClient {
void runScriptsAtDocumentElementAvailable() override;
void runScriptsAtDocumentReady(bool documentIsEmpty) override;
- void didCreateScriptContext(v8::Local<v8::Context>,
- int worldId) override;
+ void didCreateScriptContext(v8::Local<v8::Context>, int worldId) override;
void willReleaseScriptContext(v8::Local<v8::Context>, int worldId) override;
// Returns true if we should allow register V8 extensions to be added.
@@ -224,9 +224,9 @@ class FrameLoaderClientImpl final : public FrameLoaderClient {
void setHasReceivedUserGesture() override;
private:
- explicit FrameLoaderClientImpl(WebLocalFrameImpl*);
+ explicit LocalFrameClientImpl(WebLocalFrameImpl*);
- bool isFrameLoaderClientImpl() const override { return true; }
+ bool isLocalFrameClientImpl() const override { return true; }
WebDevToolsAgentImpl* devToolsAgent();
// The WebFrame that owns this object and manages its lifetime. Therefore,
@@ -236,11 +236,11 @@ class FrameLoaderClientImpl final : public FrameLoaderClient {
String m_userAgent;
};
-DEFINE_TYPE_CASTS(FrameLoaderClientImpl,
- FrameLoaderClient,
+DEFINE_TYPE_CASTS(LocalFrameClientImpl,
+ LocalFrameClient,
client,
- client->isFrameLoaderClientImpl(),
- client.isFrameLoaderClientImpl());
+ client->isLocalFrameClientImpl(),
+ client.isLocalFrameClientImpl());
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698