third_party/WebKit/Source/web/WebLocalFrameImpl.cpp - Issue 2712033002: Part 1 Of Renaming FrameLoaderClient to LocalFrameClient.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 2712033002: Part 1 Of Renaming FrameLoaderClient to LocalFrameClient. (Closed)

Patch Set: Update aliases to use "using" statement rather than typedef. Also appears I forgot to add the new f… Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

index 7a1c25a7383ffffcb86d09f88dcdbf1000fa9c86..09a25ed34feee39257a4e2d6422becd0262987d8 100644

--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

@@ -1711,10 +1711,10 @@ WebLocalFrameImpl* WebLocalFrameImpl::fromFrame(LocalFrame* frame) {

}

WebLocalFrameImpl* WebLocalFrameImpl::fromFrame(LocalFrame& frame) {

- FrameLoaderClient* client = frame.loader().client();

- if (!client || !client->isFrameLoaderClientImpl())

+ LocalFrameClient* client = frame.loader().client();

+ if (!client || !client->isLocalFrameClientImpl())

return nullptr;

- return toFrameLoaderClientImpl(client)->webFrame();

+ return toLocalFrameClientImpl(client)->webFrame();

}

WebLocalFrameImpl* WebLocalFrameImpl::fromFrameOwnerElement(Element* element) {