Part 1 Of Renaming FrameLoaderClient to LocalFrameClient.

third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.h

 /*
  * Copyright (C) 2011 Google, Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 24 matching lines @@
 #include "platform/loader/fetch/Resource.h"
 #include "platform/network/ContentSecurityPolicyParsers.h"
 #include "platform/network/HTTPParsers.h"
 #include "platform/network/ResourceRequest.h"
 #include "public/platform/WebInsecureRequestPolicy.h"
 #include "wtf/HashSet.h"
 #include "wtf/Vector.h"
 #include "wtf/text/StringHash.h"
 #include "wtf/text/TextPosition.h"
 #include "wtf/text/WTFString.h"
+

[sashab, 2017/02/24 00:27:09]

Is this needed? If it was done automatically by git cl format then its fine.

[slangley, 2017/02/24 00:39:46]

on the last cl dcheng@ said there should be vertical space between system and
user headers.

[sashab, 2017/02/24 00:44:31]

Cool.

 #include <memory>
 #include <utility>
 
 namespace WTF {
 class OrdinalNumber;
 }
 
 namespace blink {
 
 class ContentSecurityPolicyResponseHeaders;
 class ConsoleMessage;
 class CSPDirectiveList;
 class CSPSource;
 class Document;
 class Element;
-class FrameLoaderClient;
+class LocalFrameClient;
 class KURL;
 class ResourceRequest;
 class SecurityOrigin;
 class SecurityPolicyViolationEventInit;
 
 typedef int SandboxFlags;
 typedef HeapVector<Member<CSPDirectiveList>> CSPDirectiveListVector;
 typedef HeapVector<Member<ConsoleMessage>> ConsoleMessageVector;
 typedef std::pair<String, ContentSecurityPolicyHeaderType> CSPHeaderAndType;
+// TODO(slangley): Remove this once references to FrameLoaderClient are removed.
+typedef LocalFrameClient FrameLoaderClient;
 using RedirectStatus = ResourceRequest::RedirectStatus;

[sashab, 2017/02/24 00:27:09]

Do we prefer typedef or using? I'd check with dcheng, maybe it doesn't matter

[slangley, 2017/02/24 00:39:46]

typedef is how to alias types, right?

[sashab, 2017/02/24 00:44:31]

You can also use "using", which I think is the C++ way (see the line below).
"typedef" is from C.

Our C++ website says:
https://chromium-cpp.appspot.com/
C++ 'using' keyword - "Use instead of typedef, unless the header needs to be
compatible with C."

So I'd say we should find and replace "typedef LocalFrameClient
FrameLoaderClient" with "using FrameLoaderClient = LocalFrameClient".

In this case, it does the exact same thing. Maybe there are plans for a global
find+replace later.

 
 class CORE_EXPORT ContentSecurityPolicy
     : public GarbageCollectedFinalized<ContentSecurityPolicy> {
  public:
   enum ReportingStatus { SendReport, SuppressReport };
 
   enum ExceptionStatus { WillThrowException, WillNotThrowException };
 
   // This covers the possible values of a violation's 'resource', as defined in
   // https://w3c.github.io/webappsec-csp/#violation-resource. By the time we
@@ skipping 328 matching lines @@
   String m_disableEvalErrorMessage;
   WebInsecureRequestPolicy m_insecureRequestPolicy;
 
   Member<CSPSource> m_selfSource;
   String m_selfProtocol;
 };
 
 }  // namespace blink
 
 #endif