[Web Payments] Implement the credit card selection UI functionality.

chrome/browser/ui/views/payments/payment_method_view_controller_interactive_uitest.cc

Index: chrome/browser/ui/views/payments/payment_method_view_controller_interactive_uitest.cc
diff --git a/chrome/browser/ui/views/payments/payment_method_view_controller_interactive_uitest.cc b/chrome/browser/ui/views/payments/payment_method_view_controller_interactive_uitest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..2323169b8f7c6c51e6449ce628a7fa6d70cba269
--- /dev/null
+++ b/chrome/browser/ui/views/payments/payment_method_view_controller_interactive_uitest.cc
@@ -0,0 +1,123 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/views/payments/payment_request_dialog_view_ids.h"
+#include "chrome/browser/ui/views/payments/payment_request_interactive_uitest_base.h"
+#include "components/autofill/core/browser/autofill_test_utils.h"
+#include "components/autofill/core/browser/personal_data_manager.h"
+#include "components/payments/payment_request.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace payments {
+
+class PaymentMethodViewControllerTest
+    : public PaymentRequestInteractiveTestBase {
+ protected:
+  PaymentMethodViewControllerTest()
+      : PaymentRequestInteractiveTestBase(
+            "/payment_request_no_shipping_test.html") {}
+
+  PersonalDataLoadedObserverMock personal_data_observer_;
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(PaymentMethodViewControllerTest);
+};
+
+IN_PROC_BROWSER_TEST_F(PaymentMethodViewControllerTest, TestEmptyEditor) {

[Mathieu, 2017/02/24 22:51:24]

EmptyList?

Also I would rename Test from the test name

[anthonyvd, 2017/02/24 23:26:28]

Done here and below.

+  InvokePaymentRequestUI();
+  OpenPaymentMethodScreen();
+
+  views::View* list_view = dialog_view()->GetViewByID(
+      static_cast<int>(DialogViewID::PAYMENT_METHOD_SHEET_LIST_VIEW));
+  EXPECT_TRUE(list_view);
+  EXPECT_FALSE(list_view->has_children());
+}
+
+IN_PROC_BROWSER_TEST_F(PaymentMethodViewControllerTest, TestOneCardSelected) {
+  autofill::PersonalDataManager* personal_data_manager = GetDataManager();
+  personal_data_manager->AddObserver(&personal_data_observer_);
+
+  autofill::CreditCard card = autofill::test::GetCreditCard();
+  personal_data_manager->AddCreditCard(card);

[Mathieu, 2017/02/24 22:51:24]

I think I would move the Add call just before data_loop.Run()

same for others.

[anthonyvd, 2017/02/24 23:26:28]

Done.

+
+  base::RunLoop data_loop;
+  EXPECT_CALL(personal_data_observer_, OnPersonalDataChanged())
+      .WillOnce(QuitMessageLoop(&data_loop));
+  data_loop.Run();
+
+  InvokePaymentRequestUI();
+  OpenPaymentMethodScreen();
+
+  PaymentRequest* request = GetPaymentRequests(GetActiveWebContents())[0];
+  EXPECT_EQ(1U, request->credit_cards().size());
+
+  views::View* list_view = dialog_view()->GetViewByID(
+      static_cast<int>(DialogViewID::PAYMENT_METHOD_SHEET_LIST_VIEW));
+  EXPECT_TRUE(list_view);
+  EXPECT_EQ(1, list_view->child_count());
+
+  EXPECT_EQ(card, *request->selected_credit_card());
+  views::View* checkmark_view = list_view->child_at(0)->GetViewByID(
+      static_cast<int>(DialogViewID::PAYMENT_METHOD_ITEM_CHECKMARK_VIEW));
+  EXPECT_TRUE(checkmark_view->visible());
+}
+
+IN_PROC_BROWSER_TEST_F(PaymentMethodViewControllerTest,
+                       TestOneCardSelectedOutOfMany) {
+  autofill::PersonalDataManager* personal_data_manager = GetDataManager();
+  personal_data_manager->AddObserver(&personal_data_observer_);
+
+  autofill::CreditCard card1 = autofill::test::GetCreditCard();
+  autofill::CreditCard card2 = autofill::test::GetCreditCard2();
+  personal_data_manager->AddCreditCard(card1);
+
+  base::RunLoop card1_loop;
+  EXPECT_CALL(personal_data_observer_, OnPersonalDataChanged())
+      .WillOnce(QuitMessageLoop(&card1_loop));
+  card1_loop.Run();
+
+  personal_data_manager->AddCreditCard(card2);
+
+  base::RunLoop card2_loop;
+  EXPECT_CALL(personal_data_observer_, OnPersonalDataChanged())
+      .WillOnce(QuitMessageLoop(&card2_loop));
+  card2_loop.Run();
+
+  InvokePaymentRequestUI();
+  OpenPaymentMethodScreen();
+
+  PaymentRequest* request = GetPaymentRequests(GetActiveWebContents())[0];
+  EXPECT_EQ(2U, request->credit_cards().size());
+  EXPECT_EQ(card1, *request->selected_credit_card());
+
+  views::View* list_view = dialog_view()->GetViewByID(
+      static_cast<int>(DialogViewID::PAYMENT_METHOD_SHEET_LIST_VIEW));
+  EXPECT_TRUE(list_view);
+  EXPECT_EQ(2, list_view->child_count());
+
+  EXPECT_EQ(card1, *request->selected_credit_card());
+  views::View* checkmark_view = list_view->child_at(0)->GetViewByID(
+      static_cast<int>(DialogViewID::PAYMENT_METHOD_ITEM_CHECKMARK_VIEW));
+  EXPECT_TRUE(checkmark_view->visible());
+
+  views::View* checkmark_view2 = list_view->child_at(1)->GetViewByID(
+      static_cast<int>(DialogViewID::PAYMENT_METHOD_ITEM_CHECKMARK_VIEW));
+  EXPECT_FALSE(checkmark_view2->visible());
+
+  // Simulate selecting the second card.
+  ClickOnDialogViewAndWait(list_view->child_at(1));
+
+  EXPECT_EQ(card2, *request->selected_credit_card());
+  EXPECT_FALSE(checkmark_view->visible());
+  EXPECT_TRUE(checkmark_view2->visible());
+
+  // Clicking on the second card again should not modify any state.
+  ClickOnDialogViewAndWait(list_view->child_at(1));
+
+  EXPECT_EQ(card2, *request->selected_credit_card());
+  EXPECT_FALSE(checkmark_view->visible());
+  EXPECT_TRUE(checkmark_view2->visible());
+}
+
+}  // namespace payments