Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: chrome/browser/ui/views/payments/payment_method_view_controller_interactive_uitest.cc

Issue 2711973002: [Web Payments] Implement the credit card selection UI functionality. (Closed)
Patch Set: Fix test flakiness. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/ui/views/payments/payment_request_dialog_view_ids.h"
6 #include "chrome/browser/ui/views/payments/payment_request_interactive_uitest_ba se.h"
7 #include "components/autofill/core/browser/autofill_test_utils.h"
8 #include "components/autofill/core/browser/personal_data_manager.h"
9 #include "components/payments/payment_request.h"
10 #include "testing/gtest/include/gtest/gtest.h"
11
12 namespace payments {
13
14 class PaymentMethodViewControllerTest
15 : public PaymentRequestInteractiveTestBase {
16 protected:
17 PaymentMethodViewControllerTest()
18 : PaymentRequestInteractiveTestBase(
19 "/payment_request_no_shipping_test.html") {}
20
21 private:
22 DISALLOW_COPY_AND_ASSIGN(PaymentMethodViewControllerTest);
23 };
24
25 IN_PROC_BROWSER_TEST_F(PaymentMethodViewControllerTest, EmptyList) {
26 InvokePaymentRequestUI();
27 OpenPaymentMethodScreen();
28
29 views::View* list_view = dialog_view()->GetViewByID(
30 static_cast<int>(DialogViewID::PAYMENT_METHOD_SHEET_LIST_VIEW));
31 EXPECT_TRUE(list_view);
32 EXPECT_FALSE(list_view->has_children());
33 }
34
35 IN_PROC_BROWSER_TEST_F(PaymentMethodViewControllerTest, OneCardSelected) {
36 autofill::PersonalDataManager* personal_data_manager = GetDataManager();
37
38 PersonalDataLoadedObserverMock personal_data_observer;
39 personal_data_manager->AddObserver(&personal_data_observer);
40 base::RunLoop data_loop;
41 EXPECT_CALL(personal_data_observer, OnPersonalDataChanged())
42 .WillOnce(QuitMessageLoop(&data_loop));
43 autofill::CreditCard card = autofill::test::GetCreditCard();
44 personal_data_manager->AddCreditCard(card);
45 data_loop.Run();
46
47 InvokePaymentRequestUI();
48 OpenPaymentMethodScreen();
49
50 PaymentRequest* request = GetPaymentRequests(GetActiveWebContents())[0];
51 EXPECT_EQ(1U, request->credit_cards().size());
52
53 views::View* list_view = dialog_view()->GetViewByID(
54 static_cast<int>(DialogViewID::PAYMENT_METHOD_SHEET_LIST_VIEW));
55 EXPECT_TRUE(list_view);
56 EXPECT_EQ(1, list_view->child_count());
57
58 EXPECT_EQ(card, *request->selected_credit_card());
59 views::View* checkmark_view = list_view->child_at(0)->GetViewByID(
60 static_cast<int>(DialogViewID::PAYMENT_METHOD_ITEM_CHECKMARK_VIEW));
61 EXPECT_TRUE(checkmark_view->visible());
62 }
63
64 IN_PROC_BROWSER_TEST_F(PaymentMethodViewControllerTest,
65 OneCardSelectedOutOfMany) {
66 autofill::PersonalDataManager* personal_data_manager = GetDataManager();
67
68 PersonalDataLoadedObserverMock personal_data_observer1;
69 personal_data_manager->AddObserver(&personal_data_observer1);
70 base::RunLoop card1_loop;
71 EXPECT_CALL(personal_data_observer1, OnPersonalDataChanged())
72 .WillOnce(QuitMessageLoop(&card1_loop));
73 autofill::CreditCard card1 = autofill::test::GetCreditCard();
74 // Ensure that this card is the first suggestion.
75 card1.set_use_count(5U);
76 personal_data_manager->AddCreditCard(card1);
77 card1_loop.Run();
78 personal_data_manager->RemoveObserver(&personal_data_observer1);
79
80 EXPECT_EQ(1U, personal_data_manager->GetCreditCardsToSuggest().size());
81
82 PersonalDataLoadedObserverMock personal_data_observer2;
83 personal_data_manager->AddObserver(&personal_data_observer2);
84 base::RunLoop card2_loop;
85 EXPECT_CALL(personal_data_observer2, OnPersonalDataChanged())
86 .WillOnce(QuitMessageLoop(&card2_loop));
87 autofill::CreditCard card2 = autofill::test::GetCreditCard2();
88 card2.set_use_count(1U);
89 personal_data_manager->AddCreditCard(card2);
90 card2_loop.Run();
91 personal_data_manager->RemoveObserver(&personal_data_observer2);
92
93 InvokePaymentRequestUI();
94 OpenPaymentMethodScreen();
95
96 PaymentRequest* request = GetPaymentRequests(GetActiveWebContents())[0];
97 EXPECT_EQ(2U, request->credit_cards().size());
98 EXPECT_EQ(card1, *request->selected_credit_card());
99
100 views::View* list_view = dialog_view()->GetViewByID(
101 static_cast<int>(DialogViewID::PAYMENT_METHOD_SHEET_LIST_VIEW));
102 EXPECT_TRUE(list_view);
103 EXPECT_EQ(2, list_view->child_count());
104
105 EXPECT_EQ(card1, *request->selected_credit_card());
106 views::View* checkmark_view = list_view->child_at(0)->GetViewByID(
107 static_cast<int>(DialogViewID::PAYMENT_METHOD_ITEM_CHECKMARK_VIEW));
108 EXPECT_TRUE(checkmark_view->visible());
109
110 views::View* checkmark_view2 = list_view->child_at(1)->GetViewByID(
111 static_cast<int>(DialogViewID::PAYMENT_METHOD_ITEM_CHECKMARK_VIEW));
112 EXPECT_FALSE(checkmark_view2->visible());
113
114 // Simulate selecting the second card.
115 ClickOnDialogViewAndWait(list_view->child_at(1));
116
117 EXPECT_EQ(card2, *request->selected_credit_card());
118 EXPECT_FALSE(checkmark_view->visible());
119 EXPECT_TRUE(checkmark_view2->visible());
120
121 // Clicking on the second card again should not modify any state.
122 ClickOnDialogViewAndWait(list_view->child_at(1));
123
124 EXPECT_EQ(card2, *request->selected_credit_card());
125 EXPECT_FALSE(checkmark_view->visible());
126 EXPECT_TRUE(checkmark_view2->visible());
127 }
128
129 } // namespace payments
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698