[Web Payments] Implement the credit card selection UI functionality.

chrome/browser/ui/views/payments/payment_request_item_list.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/payments/payment_request_item_list.h"
 
 #include "chrome/browser/ui/views/payments/payment_request_views_util.h"
 #include "ui/views/layout/box_layout.h"
 #include "ui/views/view.h"
 
 namespace payments {
 
-PaymentRequestItemList::Item::Item() {}
+PaymentRequestItemList::Item::Item(PaymentRequestItemList* list, bool selected)
+    : list_(list), selected_(selected) {}
 
 PaymentRequestItemList::Item::~Item() {}
 
 views::View* PaymentRequestItemList::Item::GetItemView() {
   if (!item_view_) {
     item_view_ = CreateItemView();
     item_view_->set_owned_by_client();
   }
 
   return item_view_.get();
 }
 
+void PaymentRequestItemList::Item::set_selected(bool selected) {
+  selected_ = selected;
+  SelectedStateChanged();
+}
+
 PaymentRequestItemList::PaymentRequestItemList() {}
 
 PaymentRequestItemList::~PaymentRequestItemList() {}
 
 void PaymentRequestItemList::AddItem(
     std::unique_ptr<PaymentRequestItemList::Item> item) {
+  DCHECK_EQ(this, item->list());
   items_.push_back(std::move(item));
 }
 
 std::unique_ptr<views::View> PaymentRequestItemList::CreateListView() {
   std::unique_ptr<views::View> content_view = base::MakeUnique<views::View>();
 
   views::BoxLayout* layout = new views::BoxLayout(
       views::BoxLayout::kVertical, 0, kPaymentRequestRowVerticalInsets, 0);
   content_view->SetLayoutManager(layout);
 
   for (auto& item : items_) {
     content_view->AddChildView(item->GetItemView());
   }
 
   return content_view;
 }
 
+void PaymentRequestItemList::SelectItem(PaymentRequestItemList::Item* item) {

[Mathieu, 2017/02/23 21:22:53]

As a newcomer to this code, I keep having double takes between
PaymentRequestItemList and PaymentRequestItemList::Item, but it's already better
after 10mn :)

[anthonyvd, 2017/02/23 21:49:20]

Fair point. There's a bigger, overarching discussing that Tommy and myself think
we need to have about naming (ie: all our code is in payments:: but we still
name all our classes PaymentRequest*) and that should probably be part of it.

+  DCHECK_EQ(this, item->list());
+  // First, deselect the previously selected item

[Mathieu, 2017/02/23 21:22:53]

should we early abort if item->selected()

[anthonyvd, 2017/02/23 21:49:20]

Done. Also realized naming both the parameter and the loop element |item| was a
little confusing, so changed that.

+  for (auto& item : items_) {
+    if (item->selected()) {
+      item->set_selected(false);
+      break;  // Only one item is ever selected
+    }
+  }
+
+  item->set_selected(true);
+}
+
 }  // namespace payments