Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(954)

Issue 2711963002: Temporarily suppress fasta compiler hints/warnings/errors during compiling platform.dill file for t… (Closed)

Created:
3 years, 10 months ago by kustermann
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Temporarily suppress fasta compiler hints/warnings/errors during compilation of platform.dill for the patched_sdk target R=ahe@google.com Committed: https://github.com/dart-lang/sdk/commit/8b7f7b242c17145bf5bec5fa7741dad42f8c89c1

Patch Set 1 #

Patch Set 2 : Capture lines and report them in case an exception occurs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -6 lines) Patch
M tools/patch_sdk.dart View 1 2 chunks +23 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
kustermann
3 years, 10 months ago (2017-02-23 18:52:41 UTC) #2
ahe
lgtm You could also collect the output and print it in case of an exception.
3 years, 10 months ago (2017-02-23 18:56:12 UTC) #4
kustermann
On 2017/02/23 18:56:12, ahe wrote: > lgtm > > You could also collect the output ...
3 years, 10 months ago (2017-02-23 19:00:40 UTC) #5
kustermann
3 years, 10 months ago (2017-02-23 19:01:24 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
8b7f7b242c17145bf5bec5fa7741dad42f8c89c1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698