Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 27119002: Add text autosizing override in the inspector.

Created:
7 years, 2 months ago by pdr.
Modified:
7 years, 2 months ago
Reviewers:
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Add text autosizing override in the inspector. This patch has two components: 1) Changes in the inspector to add a new text autosizing override under the device metrics settings. This override has been wired up to call methods on InspectorPageAgent. 2) Blink's Settings have been changed to support overriding the text autosizing enabled boolean. A ternary enum has been added to track whether the text autosizing feature is not overridden, overridden as true, or overridden as false. Due to Blink's style guide, the m_textAutosizingOverride variable must be declared as unsigned. BUG=302005

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -40 lines) Patch
M Source/core/inspector/InspectorPageAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorPageAgent.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M Source/devtools/front_end/OverridesSupport.js View 5 chunks +39 lines, -10 lines 0 comments Download
M Source/devtools/front_end/OverridesView.js View 5 chunks +48 lines, -26 lines 0 comments Download
M Source/devtools/front_end/Settings.js View 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/protocol.json View 1 chunk +3 lines, -2 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698