Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(804)

Unified Diff: content/browser/shapedetection/shapedetection_browsertest.cc

Issue 2711893003: Shape detection: moar content_browsertests (face, qr/barcode) (Closed)
Patch Set: Make initialization of std::vector<std::vector<float>> explicit to avoid 'error: chosen constructor… Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/shape_detection/shape_detection_browsertest.cc ('k') | content/test/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/shapedetection/shapedetection_browsertest.cc
diff --git a/content/browser/shapedetection/shapedetection_browsertest.cc b/content/browser/shapedetection/shapedetection_browsertest.cc
deleted file mode 100644
index dd9f4ef546eaf7e366d6b85f19896a32335c11c7..0000000000000000000000000000000000000000
--- a/content/browser/shapedetection/shapedetection_browsertest.cc
+++ /dev/null
@@ -1,93 +0,0 @@
-// Copyright 2016 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "base/command_line.h"
-#include "base/strings/string_tokenizer.h"
-#include "content/public/common/content_switches.h"
-#include "content/public/test/browser_test_utils.h"
-#include "content/public/test/content_browser_test.h"
-#include "content/public/test/content_browser_test_utils.h"
-
-namespace content {
-
-// TODO(xianglu): Enable other platforms support. https://crbug.com/646083
-#if defined(OS_ANDROID)
-#define MAYBE_ShapeDetectionBrowserTest ShapeDetectionBrowserTest
-#else
-#define MAYBE_ShapeDetectionBrowserTest DISABLED_ShapeDetectionBrowserTest
-#endif
-
-namespace {
-
-const char kFaceDetectionTestHtml[] = "/media/face_detection_test.html";
-
-} // namespace
-
-// This class contains content_browsertests for Shape Detection API, which
-// allows for generating bounding boxes in still images.
-class MAYBE_ShapeDetectionBrowserTest : public ContentBrowserTest {
- public:
- void SetUpCommandLine(base::CommandLine* command_line) override {
- // Flag to enable ShapeDetection and DOMRect API.
- base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(
- switches::kEnableBlinkFeatures, "ShapeDetection, GeometryInterfaces");
- }
-
- protected:
- void RunDetectFacesOnImageUrl(
- const std::string& image_path,
- const std::vector<std::vector<float>>& expected_results) {
- ASSERT_TRUE(embedded_test_server()->Start());
-
- const GURL html_url(embedded_test_server()->GetURL(kFaceDetectionTestHtml));
- const GURL image_url(embedded_test_server()->GetURL(image_path));
- NavigateToURL(shell(), html_url);
- const std::string js_command =
- "detectFacesOnImageUrl('" + image_url.spec() + "')";
- std::string response_string;
- ASSERT_TRUE(
- ExecuteScriptAndExtractString(shell(), js_command, &response_string));
-
- base::StringTokenizer outer_tokenizer(response_string, "#");
- std::vector<std::vector<float>> results;
- while (outer_tokenizer.GetNext()) {
- std::string s = outer_tokenizer.token().c_str();
- std::vector<float> res;
- base::StringTokenizer inner_tokenizer(s, ",");
- while (inner_tokenizer.GetNext())
- res.push_back(atof(inner_tokenizer.token().c_str()));
- results.push_back(res);
- }
-
- ASSERT_EQ(expected_results.size(), results.size()) << "Number of faces";
- for (size_t face_id = 0; face_id < results.size(); ++face_id) {
- const std::vector<float> expected_result = expected_results[face_id];
- const std::vector<float> result = results[face_id];
- for (size_t i = 0; i < 4; ++i)
- EXPECT_NEAR(expected_result[i], result[i], 2) << "At index " << i;
- }
- }
-};
-
-IN_PROC_BROWSER_TEST_F(MAYBE_ShapeDetectionBrowserTest,
- DetectFacesOnImageWithNoFaces) {
- const std::string image_path = "/blank.jpg";
- const std::vector<std::vector<float>> expected_empty_results;
- RunDetectFacesOnImageUrl(image_path, expected_empty_results);
-}
-
-IN_PROC_BROWSER_TEST_F(MAYBE_ShapeDetectionBrowserTest,
- DetectFacesOnImageWithOneFace) {
- const std::string image_path = "/single_face.jpg";
-#if defined(OS_ANDROID)
- const std::vector<std::vector<float>> expected_results{
- {68.640625, 102.96875, 171.5625, 171.5625}};
-#else
- const std::vector<std::vector<float>> expected_results;
-#endif
-
- RunDetectFacesOnImageUrl(image_path, expected_results);
-}
-
-} // namespace content
« no previous file with comments | « content/browser/shape_detection/shape_detection_browsertest.cc ('k') | content/test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698