content/test/data/media/shape_detection_test.html - Issue 2711893003: Shape detection: moar content_browsertests (face, qr/barcode)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/test/data/media/shape_detection_test.html

Issue 2711893003: Shape detection: moar content_browsertests (face, qr/barcode) (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/browser/shape_detection/shape_detection_browsertest.cc ('K') | « content/test/data/media/face_detection_test.html ('k') | content/test/data/single_face.jpg » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 </head>	4 </head>

5	5

6 <body>	6 <body>

7 <img id="myImage">	7 <img id="myImage">

8 </body>	8 </body>

9	9

10 <script>	10 <script>

11 var img = document.getElementById("myImage");	11 var img = document.getElementById("myImage");

12	12

13 function detectFacesOnImageUrl(url) {	13 function detectShapesOnImageUrl(detector, url) {

14 img.src = url;	14 var detector = eval('new ' + detector + '()');

	15 console.log(detector);

15 img.onload = function() {	16 img.onload = function() {

16 var detector = new FaceDetector();	17 console.log('image loaded');

17 var results = "";	18 var results = "";

18 detector.detect(img)	19 detector.detect(img)

19 .then(detectedFaces => {	20 .then(detectedObjects => {

20 for (var i = 0; i < detectedFaces.length; i++) {	21 console.log('something detected');

21 var boundingBox = detectedFaces[i].boundingBox;	22 for (var i = 0; i < detectedObjects.length; i++) {

	23 var boundingBox = detectedObjects[i].boundingBox;

22 var result = boundingBox.x + "," + boundingBox.y + "," +	24 var result = boundingBox.x + "," + boundingBox.y + "," +

23 boundingBox.width + "," + boundingBox.height;	25 boundingBox.width + "," + boundingBox.height;

24 results += result + "#";	26 results += result + "#";

25 }	27 }

26 window.domAutomationController.send(results);	28 window.domAutomationController.send(results);

27 })	29 })

28 .catch(error => {	30 .catch(error => {

	31 console.log('something failed');
	Reilly Grant (use Gerrit) 2017/02/28 00:35:11 These logs seem like leftovers from development. T These logs seem like leftovers from development. That said, logging \|error.message\| might be useful. mcasas 2017/02/28 18:10:18 Done. Show quoted text On 2017/02/28 00:35:11, Reilly Grant wrote: > These logs seem like leftovers from development. That said, logging > \|error.message\| might be useful. Done.
29 error = new Error("Error during detection:" + error.message);	32 error = new Error("Error during detection:" + error.message);

30 window.domAutomationController.send(error.message);	33 window.domAutomationController.send(error.message);

31 });	34 });

32 }	35 }

	36 img.src = url;

33 }	37 }

34 </script>	38 </script>

35 </html>	39 </html>

OLD	NEW