third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.h - Issue 2711893002: Loosen FirstMeaningfulPaint UMA network-idle heuristics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.h

Issue 2711893002: Loosen FirstMeaningfulPaint UMA network-idle heuristics (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/loader/FrameLoader.cpp ('k') | third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.h

diff --git a/third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.h b/third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.h

index 6053c29f84f4118bc578d73f19ad4c1a89d6b1e9..57e11395f8e133119302111589181410d7dab76f 100644

--- a/third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.h

+++ b/third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.h

@@ -53,11 +53,15 @@ class CORE_EXPORT FirstMeaningfulPaintDetector

private:

friend class FirstMeaningfulPaintDetectorTest;

+ enum NetworkState { NetworkActive, Network2Quiet, Network0Quiet };

kouhei (in TOK) 2017/02/28 23:47:32 Optional: enum class NetworkState { Active, Quiet2

Document* document();

+ bool isNetworkQuiet(int maxActiveConnections);

void networkStableTimerFired(TimerBase*);

- enum State { NextPaintIsNotMeaningful, NextPaintIsMeaningful, Reported };

- State m_state = NextPaintIsNotMeaningful;

+ bool m_nextPaintIsMeaningful = false;

+ NetworkState m_networkState = NetworkActive;

+ NetworkState m_networkStateAtFirstMeaningfulPaint = NetworkActive;

Member<PaintTiming> m_paintTiming;

double m_provisionalFirstMeaningfulPaint = 0.0;