Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Unified Diff: third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.h

Issue 2711893002: Loosen FirstMeaningfulPaint UMA network-idle heuristics (Closed)
Patch Set: add tests, rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.h
diff --git a/third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.h b/third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.h
index 6053c29f84f4118bc578d73f19ad4c1a89d6b1e9..f63436486800fd2a4f90c6f70e1e2cd083625b74 100644
--- a/third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.h
+++ b/third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.h
@@ -54,10 +54,12 @@ class CORE_EXPORT FirstMeaningfulPaintDetector
friend class FirstMeaningfulPaintDetectorTest;
Document* document();
- void networkStableTimerFired(TimerBase*);
+ bool isNetworkQuiet(int maxActiveConnections);
+ void network0QuietTimerFired(TimerBase*);
+ void network2QuietTimerFired(TimerBase*);
+ void reportHistograms();
- enum State { NextPaintIsNotMeaningful, NextPaintIsMeaningful, Reported };
- State m_state = NextPaintIsNotMeaningful;
+ bool m_nextPaintIsMeaningful = false;
Member<PaintTiming> m_paintTiming;
double m_provisionalFirstMeaningfulPaint = 0.0;
@@ -65,7 +67,12 @@ class CORE_EXPORT FirstMeaningfulPaintDetector
double m_accumulatedSignificanceWhileHavingBlankText = 0.0;
unsigned m_prevLayoutObjectCount = 0;
bool m_seenFirstMeaningfulPaintCandidate = false;
- TaskRunnerTimer<FirstMeaningfulPaintDetector> m_networkStableTimer;
+ bool m_network0QuietReached = false;
+ bool m_network2QuietReached = false;
+ double m_firstMeaningfulPaint0Quiet = 0.0;
+ double m_firstMeaningfulPaint2Quiet = 0.0;
+ TaskRunnerTimer<FirstMeaningfulPaintDetector> m_network0QuietTimer;
+ TaskRunnerTimer<FirstMeaningfulPaintDetector> m_network2QuietTimer;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698