chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc - Issue 2711893002: Loosen FirstMeaningfulPaint UMA network-idle heuristics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

Issue 2711893002: Loosen FirstMeaningfulPaint UMA network-idle heuristics (Closed)

Patch Set: add tests, rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

diff --git a/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc b/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

index f7dd24d1ffae0817eee9e7a1e924218a79a2e89b..aaa39991a87608ea1cbcdc178878c70b50a3b5b7 100644

--- a/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

+++ b/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

@@ -640,7 +640,7 @@ IN_PROC_BROWSER_TEST_F(PageLoadMetricsBrowserTest,

embedded_test_server()->GetURL("/title1.html"));

// Wait until the renderer finishes observing layouts.

- const int kNetworkIdleTime = 500;

+ const int kNetworkIdleTime = 3000;

const int kMargin = 500;

const std::string javascript = base::StringPrintf(

"setTimeout(() => window.domAutomationController.send(true), %d)",