third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetectorTest.cpp - Issue 2711893002: Loosen FirstMeaningfulPaint UMA network-idle heuristics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetectorTest.cpp

Issue 2711893002: Loosen FirstMeaningfulPaint UMA network-idle heuristics (Closed)

Patch Set: Capture 0-stable and 2-stable independently Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.cpp ('k') | third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetectorTest.cpp

diff --git a/third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetectorTest.cpp b/third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetectorTest.cpp

index 842d2731b0604d96e2da5a3b072ac73c9e1196ee..01db68607b24c51be977eff9b5401a72615a379c 100644

--- a/third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetectorTest.cpp

+++ b/third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetectorTest.cpp

@@ -37,7 +37,11 @@ class FirstMeaningfulPaintDetectorTest : public testing::Test {

detector().notifyPaint();

}

- void simulateNetworkStable() { detector().networkStableTimerFired(nullptr); }

+ void simulateNetworkStable() {

+ document().setParsingState(Document::FinishedParsing);

+ detector().network0QuietTimerFired(nullptr);

+ detector().network2QuietTimerFired(nullptr);

tdresser 2017/03/07 17:15:51 Should we have a test where we hit the two network

Kunihiko Sakamoto 2017/03/08 04:34:51 Done.

+ }

private:

static double returnMockTime() {