third_party/WebKit/Source/core/loader/FrameLoader.cpp - Issue 2711893002: Loosen FirstMeaningfulPaint UMA network-idle heuristics

Side by Side Diff: third_party/WebKit/Source/core/loader/FrameLoader.cpp

Issue 2711893002: Loosen FirstMeaningfulPaint UMA network-idle heuristics (Closed)

Patch Set: less hacky test Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc ('k') | third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights	2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights

3 * reserved.	3 * reserved.

4 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)	4 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)

5 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved.	5 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved.

6 * (http://www.torchmobile.com/)	6 * (http://www.torchmobile.com/)

7 * Copyright (C) 2008 Alp Toker <alp@atoker.com>	7 * Copyright (C) 2008 Alp Toker <alp@atoker.com>

8 * Copyright (C) Research In Motion Limited 2009. All rights reserved.	8 * Copyright (C) Research In Motion Limited 2009. All rights reserved.

9 * Copyright (C) 2011 Kris Jordan <krisjordan@gmail.com>	9 * Copyright (C) 2011 Kris Jordan <krisjordan@gmail.com>

10 * Copyright (C) 2011 Google Inc. All rights reserved.	10 * Copyright (C) 2011 Google Inc. All rights reserved.

(...skipping 658 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
669 return true;	669 return true;

670 }	670 }

671	671

672 static bool shouldComplete(Document* document) {	672 static bool shouldComplete(Document* document) {

673 if (!document->frame())	673 if (!document->frame())

674 return false;	674 return false;

675 if (document->parsing() \|\| document->isInDOMContentLoaded())	675 if (document->parsing() \|\| document->isInDOMContentLoaded())

676 return false;	676 return false;

677 if (!document->haveImportsLoaded())	677 if (!document->haveImportsLoaded())

678 return false;	678 return false;

679 if (document->fetcher()->requestCount())	679 if (document->fetcher()->blockingRequestCount())

680 return false;	680 return false;

681 if (document->isDelayingLoadEvent())	681 if (document->isDelayingLoadEvent())

682 return false;	682 return false;

683 return allDescendantsAreComplete(document->frame());	683 return allDescendantsAreComplete(document->frame());

684 }	684 }

685	685

686 static bool shouldSendFinishNotification(LocalFrame* frame) {	686 static bool shouldSendFinishNotification(LocalFrame* frame) {

687 // Don't send didFinishLoad more than once per DocumentLoader.	687 // Don't send didFinishLoad more than once per DocumentLoader.

688 if (frame->loader().documentLoader()->sentDidFinishLoad())	688 if (frame->loader().documentLoader()->sentDidFinishLoad())

689 return false;	689 return false;

(...skipping 1290 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
1980 frameLoadRequest.clientRedirect());	1980 frameLoadRequest.clientRedirect());

1981	1981

1982 loader->setLoadType(loadType);	1982 loader->setLoadType(loadType);

1983 loader->setNavigationType(navigationType);	1983 loader->setNavigationType(navigationType);

1984 loader->setReplacesCurrentHistoryItem(loadType ==	1984 loader->setReplacesCurrentHistoryItem(loadType ==

1985 FrameLoadTypeReplaceCurrentItem);	1985 FrameLoadTypeReplaceCurrentItem);

1986 return loader;	1986 return loader;

1987 }	1987 }

1988	1988

1989 } // namespace blink	1989 } // namespace blink

OLD	NEW