third_party/WebKit/Source/core/loader/FrameLoader.cpp - Issue 2711893002: Loosen FirstMeaningfulPaint UMA network-idle heuristics

Side by Side Diff: third_party/WebKit/Source/core/loader/FrameLoader.cpp

Issue 2711893002: Loosen FirstMeaningfulPaint UMA network-idle heuristics (Closed)

Patch Set: add tests, rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc ('k') | third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.h » ('j') | third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights	2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights

3 * reserved.	3 * reserved.

4 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)	4 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)

5 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved.	5 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved.

6 * (http://www.torchmobile.com/)	6 * (http://www.torchmobile.com/)

7 * Copyright (C) 2008 Alp Toker <alp@atoker.com>	7 * Copyright (C) 2008 Alp Toker <alp@atoker.com>

8 * Copyright (C) Research In Motion Limited 2009. All rights reserved.	8 * Copyright (C) Research In Motion Limited 2009. All rights reserved.

9 * Copyright (C) 2011 Kris Jordan <krisjordan@gmail.com>	9 * Copyright (C) 2011 Kris Jordan <krisjordan@gmail.com>

10 * Copyright (C) 2011 Google Inc. All rights reserved.	10 * Copyright (C) 2011 Google Inc. All rights reserved.

(...skipping 655 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
666 return true;	666 return true;

667 }	667 }

668	668

669 static bool shouldComplete(Document* document) {	669 static bool shouldComplete(Document* document) {

670 if (!document->frame())	670 if (!document->frame())

671 return false;	671 return false;

672 if (document->parsing() \|\| document->isInDOMContentLoaded())	672 if (document->parsing() \|\| document->isInDOMContentLoaded())

673 return false;	673 return false;

674 if (!document->haveImportsLoaded())	674 if (!document->haveImportsLoaded())

675 return false;	675 return false;

676 if (document->fetcher()->requestCount())	676 if (document->fetcher()->blockingRequestCount())

677 return false;	677 return false;

678 if (document->isDelayingLoadEvent())	678 if (document->isDelayingLoadEvent())

679 return false;	679 return false;

680 return allDescendantsAreComplete(document->frame());	680 return allDescendantsAreComplete(document->frame());

681 }	681 }

682	682

683 static bool shouldSendFinishNotification(LocalFrame* frame) {	683 static bool shouldSendFinishNotification(LocalFrame* frame) {

684 // Don't send didFinishLoad more than once per DocumentLoader.	684 // Don't send didFinishLoad more than once per DocumentLoader.

685 if (frame->loader().documentLoader()->sentDidFinishLoad())	685 if (frame->loader().documentLoader()->sentDidFinishLoad())

686 return false;	686 return false;

(...skipping 1290 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
1977 frameLoadRequest.clientRedirect());	1977 frameLoadRequest.clientRedirect());

1978	1978

1979 loader->setLoadType(loadType);	1979 loader->setLoadType(loadType);

1980 loader->setNavigationType(navigationType);	1980 loader->setNavigationType(navigationType);

1981 loader->setReplacesCurrentHistoryItem(loadType ==	1981 loader->setReplacesCurrentHistoryItem(loadType ==

1982 FrameLoadTypeReplaceCurrentItem);	1982 FrameLoadTypeReplaceCurrentItem);

1983 return loader;	1983 return loader;

1984 }	1984 }

1985	1985

1986 } // namespace blink	1986 } // namespace blink

OLD	NEW