chrome/browser/ui/views/payments/editor_view_controller.h - Issue 2711873003: [Web Payments] Re-add extra view in the footer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/payments/editor_view_controller.h

Issue 2711873003: [Web Payments] Re-add extra view in the footer. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/payments/editor_view_controller.h

diff --git a/chrome/browser/ui/views/payments/editor_view_controller.h b/chrome/browser/ui/views/payments/editor_view_controller.h

index 87881990a28a06cb7845cad3dd635fb4a1660100..6e10a152fe02feb561b12ffa65ccf69bdb23a92d 100644

--- a/chrome/browser/ui/views/payments/editor_view_controller.h

+++ b/chrome/browser/ui/views/payments/editor_view_controller.h

@@ -93,7 +93,7 @@ class EditorViewController : public PaymentRequestSheetController,

// PaymentRequestSheetController:

std::unique_ptr<views::View> CreateView() override;

- std::unique_ptr<views::View> CreateLeadingFooterView() override;

+ std::unique_ptr<views::View> CreateExtraView() override;

Mathieu 2017/02/23 16:22:03 optional nit: CreateExtraFooterView? It would be m

anthonyvd 2017/02/23 16:27:34 Great suggestion, done.

virtual std::unique_ptr<views::View> CreateHeaderView() = 0;

// Returns the field definitions used to build the UI.

« no previous file with comments | « no previous file | chrome/browser/ui/views/payments/editor_view_controller.cc » ('j') | no next file with comments »