Network traffic annotation added to template_url_fetcher.

components/search_engines/template_url_fetcher.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/search_engines/template_url_fetcher.h"
 
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "build/build_config.h"
 #include "components/search_engines/template_url.h"
 #include "components/search_engines/template_url_parser.h"
 #include "components/search_engines/template_url_service.h"
 #include "net/base/load_flags.h"
+#include "net/traffic_annotation/network_traffic_annotation.h"
 #include "net/url_request/url_fetcher.h"
 #include "net/url_request/url_fetcher_delegate.h"
 #include "net/url_request/url_request_context_getter.h"
 #include "net/url_request/url_request_status.h"
 
+namespace {
+// Traffic annotation for ReqeustDelegate
+constexpr net::NetworkTrafficAnnotationTag kTrafficAnnotation =
+    net::DefineNetworkTrafficAnnotation("open_search", R"(
+      semantics {
+        sender: "Open Search Fetcher"

[Peter Kasting, 2017/02/24 23:33:09]

I think this should be Omnibox, as that's ultimately the larger feature this is
part of.

[Ramin Halavati, 2017/02/27 09:07:57]

Done.

[vasilii, 2017/02/27 13:14:01]

Peter, why omnibox? If I search for "yandex" and then click the first link on
the Google result page, the search engine is still registered. Despite I didn't
do anything with the omnibox.

[Peter Kasting, 2017/02/27 21:07:10]

Because that's what these search engines are actually used for: tab-to-search in
the omnibox.

In other words, this is "used by" rather than "caused by".

+        description:
+          "The web pages can include an OpenSearch description doc in their "

[Peter Kasting, 2017/02/24 23:33:09]

Nit: No "the"

[Ramin Halavati, 2017/02/27 09:07:57]

Done.

+          "HTML. In this case Chromium downloads and parses the file. The "

[Peter Kasting, 2017/02/24 23:33:09]

Is merely visiting the page, and not actually using the search engine, enough to
trigger this?

[vasilii, 2017/02/27 12:13:05]

Yes, you can land on https://yandex.ru/ and observe a new entry in
chrome://settings/searchEngines

+          "corresponding search engine is added to the list in the browser "
+          "(chrome://settings/searchEngines)."
+        trigger:
+          "User visits a web page containing  <link rel="search"> tag."

[Peter Kasting, 2017/02/24 23:33:09]

Nit: Two spaces after "containing" should be " a " instead.

[Ramin Halavati, 2017/02/27 09:07:57]

Done.

+        data: "None"
+        destination: WEBSITE
+      }
+      policy {
+        cookies_allowed: false

[vasilii, 2017/02/24 15:05:43]

true

+        setting: "This feature cannot be disabled in settings."
+        policy_exception_justification:
+          "Not implemented, considered not useful as this feature does not "
+          "upload any data."

[Peter Kasting, 2017/02/24 23:33:09]

Since we send cookies, this seems incorrect.

Maybe we shouldn't send/save cookies with this request?

[vasilii, 2017/02/27 12:13:06]

I didn't find anything related to cookies in the spec
(http://www.opensearch.org/Specifications/OpenSearch/1.1#Autodiscovery_in_HTML...).
From the privacy perspective it doesn't bring a lot as the link may contain the
user id.
There is a problem with using the user request context in the browser process
(https://crbug.com/675944 and https://codereview.chromium.org/2249213002/). The
request may poison the main profile. A short-term quick fix proposed was the
combination net::LOAD_DO_NOT_SEND_COOKIES | net::LOAD_DO_NOT_SAVE_COOKIES |
net::LOAD_DO_NOT_SEND_AUTH_DATA. I suggest we apply it here. 

+      })");
+}  // namespace
+
 // RequestDelegate ------------------------------------------------------------
 class TemplateURLFetcher::RequestDelegate : public net::URLFetcherDelegate {
  public:
   RequestDelegate(
       TemplateURLFetcher* fetcher,
       const base::string16& keyword,
       const GURL& osdd_url,
       const GURL& favicon_url,
       const URLFetcherCustomizeCallback& url_fetcher_customize_callback);
 
@@ skipping 23 matching lines @@
 
   DISALLOW_COPY_AND_ASSIGN(RequestDelegate);
 };
 
 TemplateURLFetcher::RequestDelegate::RequestDelegate(
     TemplateURLFetcher* fetcher,
     const base::string16& keyword,
     const GURL& osdd_url,
     const GURL& favicon_url,
     const URLFetcherCustomizeCallback& url_fetcher_customize_callback)
-    : url_fetcher_(
-          net::URLFetcher::Create(osdd_url, net::URLFetcher::GET, this)),
+    : url_fetcher_(net::URLFetcher::Create(osdd_url,
+                                           net::URLFetcher::GET,
+                                           this,
+                                           kTrafficAnnotation)),
       fetcher_(fetcher),
       keyword_(keyword),
       osdd_url_(osdd_url),
       favicon_url_(favicon_url) {
   TemplateURLService* model = fetcher_->template_url_service_;
   DCHECK(model);  // TemplateURLFetcher::ScheduleDownload verifies this.
 
   if (!model->loaded()) {
     // Start the model load and set-up waiting for it.
     template_url_subscription_ = model->RegisterOnLoadedCallback(
@@ skipping 142 matching lines @@
 }
 
 void TemplateURLFetcher::RequestCompleted(RequestDelegate* request) {
   auto i = std::find_if(requests_.begin(), requests_.end(),
                         [request](const std::unique_ptr<RequestDelegate>& ptr) {
                           return ptr.get() == request;
                         });
   DCHECK(i != requests_.end());
   requests_.erase(i);
 }