Add AstBuilder support for enum declarations.

Add AstBuilder support for enum declarations.

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/5e997051cf57261a8ece089b3c5ddc8b2384d97f

[Paul Berry, 2017-02-22 21:56:08]

paulberry@google.com changed reviewers:
+ ahe@google.com, scheglov@google.com

[scheglov, 2017-02-22 21:58:05]

LGTM

[Paul Berry, 2017-02-22 22:11:30]

Description was changed from

==========
Add AstBuilder support for enum declarations.
==========

to

==========
Add AstBuilder support for enum declarations.

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/5e997051cf57261a8ece089b3c5ddc8b2384d97f
==========

[Paul Berry, 2017-02-22 22:11:31]

Committed patchset #1 (id:1) manually as
5e997051cf57261a8ece089b3c5ddc8b2384d97f (presubmit successful).

[ahe, 2017-02-23 16:47:25]

lgtm

https://codereview.chromium.org/2711813002/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart (right):

https://codereview.chromium.org/2711813002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart:126: // metadata, but the
spec doesn't permit it.
I think we should accept it for error recovery.

https://codereview.chromium.org/2711813002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart:1092: var openBrace =
enumKeyword.next.next as BeginGroupToken;
I would recommend against casts as they have to be checked at runtime. Instead,
this works well:

BeginGroupToken openBrace = enumKeyword.next.next;

https://codereview.chromium.org/2711813002/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart:1094: // error recovery?
The scanner always provides a synthetic end token. The problem is actually on
the previous statement, if a { was missing. I don't think the parser can recover
from that today, though.