Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h

Issue 2711803007: Add ClearanceOffset to LayoutNG Constraint space. (Closed)
Patch Set: update TestExpectations Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h
index 61549af0b465dfc9239989189ac5753feba64e9b..526ce6cac2ab35ef37bfa224edf20f12ee737e30 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h
+++ b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h
@@ -7,6 +7,7 @@
#include "core/layout/ng/ng_constraint_space.h"
#include "core/layout/ng/ng_units.h"
+#include "wtf/Optional.h"
namespace blink {
@@ -46,10 +47,10 @@ class CORE_EXPORT NGConstraintSpaceBuilder final
NGConstraintSpaceBuilder& SetMarginStrut(const NGMarginStrut& margin_strut);
- NGConstraintSpaceBuilder& SetBfcOffset(const NGLogicalOffset& offset) {
- bfc_offset_ = offset;
- return *this;
- }
+ NGConstraintSpaceBuilder& SetBfcOffset(const NGLogicalOffset& offset);
+
+ NGConstraintSpaceBuilder& SetClearanceOffset(
+ const WTF::Optional<LayoutUnit>& clearance_offset);
// Creates a new constraint space. This may be called multiple times, for
// example the constraint space will be different for a child which:
@@ -84,6 +85,7 @@ class CORE_EXPORT NGConstraintSpaceBuilder final
NGMarginStrut margin_strut_;
NGLogicalOffset bfc_offset_;
std::shared_ptr<NGExclusions> exclusions_;
+ WTF::Optional<LayoutUnit> clearance_offset_;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698