Issue 2711753002: fasta: Use List instead of List<Object> because analyzer code assigns it to List<Token>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2711753002: fasta: Use List instead of List<Object> because analyzer code assigns it to List<Token> (Closed)

Created:
3 years, 10 months ago by kustermann

Modified:
3 years, 10 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

fasta: Use List instead of List<Object> because analyzer code assigns it to List<Token> Committed: https://github.com/dart-lang/sdk/commit/237959c9a6881a7ed9518c35f69bf9af38d751b5

Patch Set 1 #

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	pkg/front_end/lib/src/fasta/source/stack_listener.dart	View		2 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

kustermann

TBR to get buildbot green. It wasn't caught by running: DART_SDK=out/ReleaseX64/dart-sdk out/ReleaseX64/dart-sdk/bin/dart pkg/testing/bin/testing.dart --config=pkg/front_end/test/fasta/testing.json --verbose ...

3 years, 10 months ago (2017-02-22 14:59:15 UTC) #2

kustermann

Committed patchset #1 (id:1) manually as 237959c9a6881a7ed9518c35f69bf9af38d751b5 (presubmit successful).

3 years, 10 months ago (2017-02-22 15:01:20 UTC) #4

ahe

3 years, 10 months ago (2017-02-22 18:23:54 UTC) #5

Message was sent while issue was closed.

lgtm

Let's investigate why the tests didn't catch this tomorrow.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages