Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Unified Diff: chrome/browser/prerender/prerender_unittest.cc

Issue 2711693002: [Offline Pages] Make prerenderer notify us of network progress. (Closed)
Patch Set: last minute fixes Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prerender/prerender_unittest.cc
diff --git a/chrome/browser/prerender/prerender_unittest.cc b/chrome/browser/prerender/prerender_unittest.cc
index be3bfa0e35b69dbc139614fb9a7b89b77756182d..f949fc83c4f325ecbd806c18f20696daf3358455 100644
--- a/chrome/browser/prerender/prerender_unittest.cc
+++ b/chrome/browser/prerender/prerender_unittest.cc
@@ -96,6 +96,30 @@ class DummyPrerenderContents : public PrerenderContents {
FinalStatus expected_final_status_;
};
+class TestNetworkBytesChangedObserver
+ : public prerender::PrerenderHandle::Observer {
+ public:
+ TestNetworkBytesChangedObserver() : network_bytes_changed_(false) {}
+
+ // prerender::PrerenderHandle::Observer
+ void OnPrerenderStart(PrerenderHandle* prerender_handle) override {}
+ void OnPrerenderStopLoading(PrerenderHandle* prerender_handle) override {}
+ void OnPrerenderDomContentLoaded(PrerenderHandle* prerender_handle) override {
+ }
+ void OnPrerenderStop(PrerenderHandle* prerender_handle) override {}
+ void OnPrerenderNetworkBytesChanged(
+ PrerenderHandle* prerender_handle) override {
+ network_bytes_changed_ = true;
+ }
+
+ bool network_bytes_changed() const { return network_bytes_changed_; }
+
+ private:
+ bool network_bytes_changed_;
+
+ DISALLOW_COPY_AND_ASSIGN(TestNetworkBytesChangedObserver);
+};
+
int DummyPrerenderContents::g_next_route_id_ = 0;
const gfx::Size kSize(640, 480);
@@ -1999,4 +2023,20 @@ TEST_F(PrerenderTest, PrerenderContentsIsValidHttpMethod) {
EXPECT_FALSE(prerender_contents->IsValidHttpMethod("WHATEVER"));
}
+TEST_F(PrerenderTest, PrerenderContentsIncrementsByteCount) {
+ GURL url("http://www.google.com/");
+ DummyPrerenderContents* prerender_contents = nullptr;
+ prerender_contents = prerender_manager()->CreateNextPrerenderContents(
+ url, ORIGIN_OFFLINE, FINAL_STATUS_MANAGER_SHUTDOWN);
+ std::unique_ptr<PrerenderHandle> prerender_handle =
+ prerender_manager()->AddPrerenderForOffline(url, nullptr, kSize);
+
+ TestNetworkBytesChangedObserver observer;
+ prerender_handle->SetObserver(&observer);
+
+ prerender_contents->AddNetworkBytes(12);
+ EXPECT_TRUE(observer.network_bytes_changed());
+ EXPECT_EQ(12, prerender_contents->network_bytes());
+}
+
} // namespace prerender

Powered by Google App Engine
This is Rietveld 408576698