Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Unified Diff: chrome/browser/android/offline_pages/prerendering_loader.h

Issue 2711693002: [Offline Pages] Make prerenderer notify us of network progress. (Closed)
Patch Set: last minute fixes Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/prerendering_loader.h
diff --git a/chrome/browser/android/offline_pages/prerendering_loader.h b/chrome/browser/android/offline_pages/prerendering_loader.h
index df541103861981443ec90739bcb7acbced0e423a..9ea9c84c7500626cbb73b75b94c469c3090ca68c 100644
--- a/chrome/browser/android/offline_pages/prerendering_loader.h
+++ b/chrome/browser/android/offline_pages/prerendering_loader.h
@@ -32,6 +32,8 @@ class PrerenderingLoader : public PrerenderAdapter::Observer,
typedef base::Callback<void(Offliner::RequestStatus, content::WebContents*)>
LoadPageCallback;
+ typedef base::Callback<void(int64_t)> ProgressCallback;
+
explicit PrerenderingLoader(content::BrowserContext* browser_context);
~PrerenderingLoader() override;
@@ -43,7 +45,9 @@ class PrerenderingLoader : public PrerenderAdapter::Observer,
// once - first for a successful load and then if canceled after the
// load (which may be from resources being reclaimed) at which point
// the retrieved WebContents should no longer be used.
- virtual bool LoadPage(const GURL& url, const LoadPageCallback& callback);
+ virtual bool LoadPage(const GURL& url,
+ const LoadPageCallback& load_done_callback,
+ const ProgressCallback& progress_callback);
// Stops (completes or cancels) the load request. Must be called when
// LoadPageCallback is done with consuming the contents. May be called
@@ -70,6 +74,7 @@ class PrerenderingLoader : public PrerenderAdapter::Observer,
void OnPrerenderStopLoading() override;
void OnPrerenderDomContentLoaded() override;
void OnPrerenderStop() override;
+ void OnPrerenderNetworkBytesChanged(int64_t bytes) override;
// SnapshotController::Client implementation:
void StartSnapshot() override;
@@ -114,7 +119,10 @@ class PrerenderingLoader : public PrerenderAdapter::Observer,
// Callback to call when the active load request completes, fails, or is
// canceled.
- LoadPageCallback callback_;
+ LoadPageCallback load_done_callback_;
+
+ // Callback to call when we know more bytes have loaded from the network.
+ ProgressCallback progress_callback_;
DISALLOW_COPY_AND_ASSIGN(PrerenderingLoader);
};

Powered by Google App Engine
This is Rietveld 408576698