[Offline Pages] Make prerenderer notify us of network progress.

chrome/browser/prerender/prerender_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <map>
 #include <utility>
 
@@ skipping 78 matching lines @@
   }
 
  private:
   static int g_next_route_id_;
   int route_id_;
 
   UnitTestPrerenderManager* test_prerender_manager_;
   FinalStatus expected_final_status_;
 };
 
+class TestPrerenderHandleObserver

[pasko-google - do not use, 2017/02/22 13:32:44]

Can we have a more specialized name like NetworkBytesChangedObserver? This would
make it more obvious what the class does down in the test.

[Dmitry Titov, 2017/02/23 04:27:54]

Done.

+    : public prerender::PrerenderHandle::Observer {
+ public:
+  void OnPrerenderStart(PrerenderHandle* prerender_handle) override {}
+  void OnPrerenderStopLoading(PrerenderHandle* prerender_handle) override {}
+  void OnPrerenderDomContentLoaded(PrerenderHandle* prerender_handle) override {
+  }
+  void OnPrerenderStop(PrerenderHandle* prerender_handle) override {}
+  void OnPrerenderNetworkBytesChanged(
+      PrerenderHandle* prerender_handle) override {
+    network_bytes_changed = true;

[pasko-google - do not use, 2017/02/22 13:32:44]

even though it is a simple class, let's follow the coding style: make members
private, name them appropriately, DISALLOW_COPY_AND_ASSIGN.

[Dmitry Titov, 2017/02/23 04:27:54]

Done.

+  }
+
+  bool network_bytes_changed = false;

[pasko-google - do not use, 2017/02/22 13:32:44]

member initializers outside constructors are allowed, but not common in
prerender code. Please move to constructor for consistency.

[Dmitry Titov, 2017/02/23 04:27:55]

Done.

+};
+
 int DummyPrerenderContents::g_next_route_id_ = 0;
 
 const gfx::Size kSize(640, 480);
 
 const uint32_t kDefaultRelTypes = PrerenderRelTypePrerender;
 
 base::SimpleTestTickClock* OverridePrerenderManagerTimeTicks(
     PrerenderManager* prerender_manager) {
   auto tick_clock = base::MakeUnique<base::SimpleTestTickClock>();
   base::SimpleTestTickClock* tick_clock_ptr = tick_clock.get();
@@ skipping 1883 matching lines @@
 
   prerender_contents->SetPrerenderMode(PREFETCH_ONLY);
   EXPECT_TRUE(prerender_contents->IsValidHttpMethod("GET"));
   EXPECT_TRUE(prerender_contents->IsValidHttpMethod("HEAD"));
   EXPECT_FALSE(prerender_contents->IsValidHttpMethod("OPTIONS"));
   EXPECT_FALSE(prerender_contents->IsValidHttpMethod("POST"));
   EXPECT_FALSE(prerender_contents->IsValidHttpMethod("TRACE"));
   EXPECT_FALSE(prerender_contents->IsValidHttpMethod("WHATEVER"));
 }
 
+TEST_F(PrerenderTest, PrerenderContentsIncrementsByteCount) {
+  GURL url("http://www.google.com/");
+  DummyPrerenderContents* prerender_contents = nullptr;
+  prerender_contents = prerender_manager()->CreateNextPrerenderContents(
+      url, ORIGIN_OFFLINE, FINAL_STATUS_MANAGER_SHUTDOWN);
+  std::unique_ptr<PrerenderHandle> prerender_handle =
+      prerender_manager()->AddPrerenderForOffline(url, nullptr, kSize);
+
+  TestPrerenderHandleObserver observer;
+  prerender_handle->SetObserver(&observer);
+
+  prerender_contents->AddNetworkBytes(12);
+  EXPECT_TRUE(observer.network_bytes_changed);
+  EXPECT_EQ(12, prerender_contents->network_bytes());
+}
+
 }  // namespace prerender