Fix Physical Web WebUI broken favicon

chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlInfo.java

Index: chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlInfo.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlInfo.java b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlInfo.java
index f32fb59468603478801ba2abf2c10f84ef11dab2..f6e2494e57e0c2f009904f8f3d17fba7084652b3 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlInfo.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlInfo.java
@@ -15,19 +15,19 @@ import java.util.Locale;
 class UrlInfo {
     private static final String URL_KEY = "url";
     private static final String DISTANCE_KEY = "distance";
-    private static final String SCAN_TIMESTAMP_KEY = "scan_timestamp";
+    private static final String LASTSEEN_TIMESTAMP_KEY = "lastseen_timestamp";

[mattreynolds, 2017/02/22 23:33:42]

Shouldn't this be first seen, not last seen? (according to the commit message)

Also, could you rename this to put a space before "seen", for instance:

private static final String FIRST_SEEN_TIMESTAMP_KEY = "first_seen_timestamp";

[Ran, 2017/02/23 19:44:13]

Done.

     private static final String DEVICE_ADDRESS_KEY = "device_address";
     private static final String HAS_BEEN_DISPLAYED_KEY = "has_been_displayed";
     private final String mUrl;
     private double mDistance;
-    private long mScanTimestamp;
+    private long mLastSeenTimestamp;
     private String mDeviceAddress;
     private boolean mHasBeenDisplayed;
 
-    public UrlInfo(String url, double distance, long scanTimestamp) {
+    public UrlInfo(String url, double distance, long lastSeenTimestamp) {
         mUrl = url;
         mDistance = distance;
-        mScanTimestamp = scanTimestamp;
+        mLastSeenTimestamp = lastSeenTimestamp;
         mDeviceAddress = null;
         mHasBeenDisplayed = false;
     }
@@ -67,20 +67,20 @@ class UrlInfo {
     /**
      * Sets the timestamp of when the URL was last scanned.
      * This timestamp should be recorded using System.currentTimeMillis().
-     * @param scanTimestamp the new timestamp.
+     * @param lastSeenTimestamp the new timestamp.
      */
-    public UrlInfo setScanTimestamp(long scanTimestamp) {
-        mScanTimestamp = scanTimestamp;
+    public UrlInfo setLastSeenTimestamp(long lastSeenTimestamp) {

[mattreynolds, 2017/02/22 23:33:42]

If we don't need to update the timestamp anymore, let's remove this setter and
make the field final.

[Ran, 2017/02/23 19:44:13]

Done.

+        mLastSeenTimestamp = lastSeenTimestamp;
         return this;
     }
 
     /**
      * Gets the timestamp of when the URL was last scanned.
      * This timestamp is recorded using System.currentTimeMillis().
-     * @return The scan timestamp.
+     * @return The lastseen timestamp.

[mattreynolds, 2017/02/22 23:33:42]

"The lastseen timestamp" is awkward. I think the javadoc already does a good job
of explaining what is returned, so you could change this to "The timestamp." or
remove the @return line altogether.

[Ran, 2017/02/23 19:44:13]

Done.

      */
-    public long getScanTimestamp() {
-        return mScanTimestamp;
+    public long getLastSeenTimestamp() {
+        return mLastSeenTimestamp;
     }
 
     /**
@@ -126,7 +126,7 @@ class UrlInfo {
         return new JSONObject()
                 .put(URL_KEY, mUrl)
                 .put(DISTANCE_KEY, mDistance)
-                .put(SCAN_TIMESTAMP_KEY, mScanTimestamp)
+                .put(LASTSEEN_TIMESTAMP_KEY, mLastSeenTimestamp)
                 .put(DEVICE_ADDRESS_KEY, mDeviceAddress)
                 .put(HAS_BEEN_DISPLAYED_KEY, mHasBeenDisplayed);
     }
@@ -141,7 +141,7 @@ class UrlInfo {
         UrlInfo urlInfo = new UrlInfo(
                 jsonObject.getString(URL_KEY),
                 jsonObject.getDouble(DISTANCE_KEY),
-                jsonObject.getLong(SCAN_TIMESTAMP_KEY))
+                jsonObject.getLong(LASTSEEN_TIMESTAMP_KEY))
                 .setDeviceAddress(jsonObject.optString(DEVICE_ADDRESS_KEY));
         if (jsonObject.optBoolean(HAS_BEEN_DISPLAYED_KEY, false)) {
             urlInfo.setHasBeenDisplayed();
@@ -155,6 +155,6 @@ class UrlInfo {
     @Override
     public String toString() {
         return String.format(Locale.getDefault(), "%s %f %d %b",
-                mUrl, mDistance, mScanTimestamp, mHasBeenDisplayed);
+                mUrl, mDistance, mLastSeenTimestamp, mHasBeenDisplayed);
     }
-}
+}