Fix Physical Web WebUI broken favicon

chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.physicalweb;
 
 import android.content.Context;
 import android.content.SharedPreferences;
 import android.os.AsyncTask;
 import android.os.Handler;
@@ skipping 418 matching lines @@
      * previously undiscovered.
      * @return The updated cache entry
      */
     private UrlInfo updateCacheEntry(UrlInfo urlInfo) {
         UrlInfo currentUrlInfo = mUrlInfoMap.get(urlInfo.getUrl());
         if (currentUrlInfo == null) {
             mUrlInfoMap.put(urlInfo.getUrl(), urlInfo);
             currentUrlInfo = urlInfo;
         } else {
             mUrlsSortedByTimestamp.remove(urlInfo.getUrl());
-            currentUrlInfo.setScanTimestamp(urlInfo.getScanTimestamp());
+
+            // TODO(ranj): Update scantimestamp when metadata is refreshed appropriately.
+            // currentUrlInfo.setScanTimestamp(urlInfo.getScanTimestamp());

[mmocny, 2017/02/22 19:36:52]

If we don't update this here, won't these results get garbage collected too
early?

[cco3, 2017/02/22 20:21:47]

Yes, but that's OK.  time-based garbage collection had mostly to do with
notification frequency (so that after 24 hours, swipes would be reset).  In
fact, now that we don't have notifications, it might be worth reconsidering why
we have a cache for anything other than PwsResults

             if (urlInfo.getDistance() > 0.0) {
                 currentUrlInfo.setDistance(urlInfo.getDistance());
             }
             if (urlInfo.getDeviceAddress() != null) {
                 currentUrlInfo.setDeviceAddress(urlInfo.getDeviceAddress());
             }
         }
         mUrlsSortedByTimestamp.add(urlInfo.getUrl());
         return currentUrlInfo;
     }
@@ skipping 193 matching lines @@
 
     private native long nativeInit();
     private native void nativeAppendMetadataItem(long nativePhysicalWebCollection,
             String requestUrl, double distanceEstimate, long scanTimestamp, String siteUrl,
             String iconUrl, String title, String description, String groupId);
     private native void nativeOnFound(long nativePhysicalWebDataSourceAndroid, String url);
     private native void nativeOnLost(long nativePhysicalWebDataSourceAndroid, String url);
     private native void nativeOnDistanceChanged(
             long nativePhysicalWebDataSourceAndroid, String url, double distanceChanged);
 }