(Set)IsOverridingUserAgent should be called on VisibleItem

ios/chrome/browser/tabs/tab.mm

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/tabs/tab.h"
 
 #import <CoreLocation/CoreLocation.h>
 #import <UIKit/UIKit.h>
 
 #include <utility>
@@ skipping 1507 matching lines @@
 
   [self.readerModeController exitReaderMode];
 }
 
 #pragma mark -
 
 - (void)openAppStore:(NSString*)appId {
   [storeKitLauncher_ openAppStore:appId];
 }
 
 - (BOOL)useDesktopUserAgent {

[kkhorimoto, 2017/02/22 01:08:40]

The naming of this property is a little confusing, as it's using an imperative
voice (i.e. by the name of the function, I would expect that calling this would
instruct the Tab to begin using a desktop UA).  Can we rename the property as
follows?

@property(nonatomic, readonly, getter=isUsingDesktopUserAgent) BOOL
usingDesktopUserAgent?

- (BOOL)usingDesktopUserAgent {
  return [self navigationManager]->IsUsingDesktopUserAgent();
}

[kkhorimoto, 2017/02/22 01:16:32]

Oops, made a mistake, the implementation would be:

- (BOOL)isUsingDesktopUserAgent {
  return [self navigationManager]->IsUsingDesktopUserAgent();
}

[liaoyuke, 2017/02/22 01:37:43]

yeah, I also don't like the name of the function, but in Android, it's named
getUseDesktopUserAgent
https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chr...

Do we want to follow Android's name or change it to isUsingDesktopUserAgent?

[kkhorimoto, 2017/02/22 01:54:33]

I think we should go ahead and use isUsingDesktopUserAgent.  content// and
Android have been around for longer, which is why we often use them as a
reference for implementation details, but naming/style doesn't have to match
exactly.  Given that renaming this would increase readability of the code, I'd
say this is a good place where we should diverge.

Also, just a heads up...when defining BOOL properties where the getter is
different from the property name, you use the property name when accessing via
dot notation and the getter name when accessing using selector notation:

@property(nonatomic, readonly, getter=isUsingDesktopUserAgent) BOOL
usingDesktopUserAgent;

should be accessed as:
tab.usingDesktopUserAgent OR [tab isUsingDesktopUserAgent]

-  web::NavigationItem* currentItem = self.currentNavigationItem;
-  return currentItem && currentItem->IsOverridingUserAgent();
+  return [self navigationManager]->GetUseDesktopUserAgent();
 }
 
 - (void)enableDesktopUserAgent {
   DCHECK_EQ(self.useDesktopUserAgent, NO);
   DCHECK([self navigationManager]);
   [self navigationManager]->OverrideDesktopUserAgentForNextPendingItem();
 }
 
 - (void)reloadForDesktopUserAgent {
   // |loadWithParams| will recreate the removed UIWebView.
@@ skipping 669 matching lines @@
 
 - (TabModel*)parentTabModel {
   return parentTabModel_;
 }
 
 - (FormInputAccessoryViewController*)inputAccessoryViewController {
   return inputAccessoryViewController_.get();
 }
 
 @end