ios/chrome/browser/ui/browser_view_controller_dependency_factory.mm - Issue 2711623003: Update infobars to use VectorIcon struct instead of VectorIconId.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/browser_view_controller_dependency_factory.mm

Issue 2711623003: Update infobars to use VectorIcon struct instead of VectorIconId. (Closed)

Patch Set: move extension.icon Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/startup/bad_flags_prompt.cc ('K') | « components/infobars/core/simple_alert_infobar_delegate.cc ('k') | ui/gfx/vector_icons/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/ui/browser_view_controller_dependency_factory.mm

diff --git a/ios/chrome/browser/ui/browser_view_controller_dependency_factory.mm b/ios/chrome/browser/ui/browser_view_controller_dependency_factory.mm

index fdb89c2f7c87415221b224b33136f4bafc77bf86..6e4ff2014e0709e0aa0528391da00be7e514c192 100644

--- a/ios/chrome/browser/ui/browser_view_controller_dependency_factory.mm

+++ b/ios/chrome/browser/ui/browser_view_controller_dependency_factory.mm

@@ -52,8 +52,7 @@ NSString* const kBrowserViewControllerSnackbarCategory =

DCHECK(infoBarManager);

SimpleAlertInfoBarDelegate::Create(

infoBarManager,

- infobars::InfoBarDelegate::SHOW_PASSKIT_INFOBAR_ERROR_DELEGATE,

- infobars::InfoBarDelegate::kNoIconID, gfx::VectorIconId::VECTOR_ICON_NONE,

+ infobars::InfoBarDelegate::SHOW_PASSKIT_INFOBAR_ERROR_DELEGATE, nullptr,

Peter Kasting 2017/02/24 02:12:27 Maybe this is another /!\ candidate.

Evan Stade 2017/02/24 17:18:16 no idea what this even is. "Sorry, your Pass canno

l10n_util::GetStringUTF16(IDS_IOS_GENERIC_PASSKIT_ERROR), true);

}

« chrome/browser/ui/startup/bad_flags_prompt.cc ('K') | « components/infobars/core/simple_alert_infobar_delegate.cc ('k') | ui/gfx/vector_icons/BUILD.gn » ('j') | no next file with comments »