Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(50)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Unified Diff: chrome/app/vector_icons/sad_tab.icon
Issue
2711623003
:
Update infobars to use VectorIcon struct instead of VectorIconId. (Closed)
Patch Set: move extension.icon
Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Jump to:
chrome/app/vector_icons/BUILD.gn
chrome/app/vector_icons/OWNERS
chrome/app/vector_icons/apps.icon
chrome/app/vector_icons/cookie.icon
chrome/app/vector_icons/extension.icon
chrome/app/vector_icons/extension_crashed.icon
chrome/app/vector_icons/globe.icon
chrome/app/vector_icons/paintbrush.icon
chrome/app/vector_icons/sad_tab.icon
chrome/browser/banners/app_banner_infobar_delegate_desktop.h
chrome/browser/banners/app_banner_infobar_delegate_desktop.cc
chrome/browser/extensions/BUILD.gn
chrome/browser/extensions/extension_icon_manager.cc
chrome/browser/extensions/theme_installed_infobar_delegate.h
chrome/browser/extensions/theme_installed_infobar_delegate.cc
chrome/browser/pepper_broker_infobar_delegate.h
chrome/browser/pepper_broker_infobar_delegate.cc
chrome/browser/permissions/permission_request_impl.cc
chrome/browser/plugins/plugin_infobar_delegates.h
chrome/browser/plugins/plugin_infobar_delegates.cc
chrome/browser/plugins/plugin_observer.cc
chrome/browser/ui/chrome_select_file_policy.cc
chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm
chrome/browser/ui/collected_cookies_infobar_delegate.h
chrome/browser/ui/collected_cookies_infobar_delegate.cc
chrome/browser/ui/hung_plugin_tab_helper.cc
chrome/browser/ui/omnibox/alternate_nav_infobar_delegate.h
chrome/browser/ui/omnibox/alternate_nav_infobar_delegate.cc
chrome/browser/ui/startup/bad_flags_prompt.cc
chrome/browser/ui/startup/default_browser_infobar_delegate.h
chrome/browser/ui/startup/default_browser_infobar_delegate.cc
chrome/browser/ui/startup/session_crashed_infobar_delegate.h
chrome/browser/ui/startup/session_crashed_infobar_delegate.cc
chrome/browser/ui/website_settings/website_settings_infobar_delegate.h
chrome/browser/ui/website_settings/website_settings_infobar_delegate.cc
components/infobars/core/infobar_delegate.h
components/infobars/core/infobar_delegate.cc
components/infobars/core/simple_alert_infobar_delegate.h
components/infobars/core/simple_alert_infobar_delegate.cc
ios/chrome/browser/ui/browser_view_controller_dependency_factory.mm
ui/gfx/vector_icons/BUILD.gn
ui/gfx/vector_icons/apps.icon
ui/gfx/vector_icons/extension_crashed.icon
ui/gfx/vector_icons/globe.icon
ui/gfx/vector_icons/paintbrush.icon
ui/gfx/vector_icons/sad_tab.icon
ui/vector_icons/BUILD.gn
ui/vector_icons/extension.icon
View side-by-side diff with in-line comments
Download patch
« no previous file with comments
|
« chrome/app/vector_icons/paintbrush.icon
('k') |
chrome/browser/banners/app_banner_infobar_delegate_desktop.h »
('j') |
chrome/browser/ui/chrome_select_file_policy.cc »
('J')
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
Index: chrome/app/vector_icons/sad_tab.icon
diff --git a/ui/gfx/vector_icons/sad_tab.icon b/chrome/app/vector_icons/sad_tab.icon
similarity index 100%
rename from ui/gfx/vector_icons/sad_tab.icon
rename to chrome/app/vector_icons/sad_tab.icon
« no previous file with comments
|
« chrome/app/vector_icons/paintbrush.icon
('k') |
chrome/browser/banners/app_banner_infobar_delegate_desktop.h »
('j') |
chrome/browser/ui/chrome_select_file_policy.cc »
('J')
Issue 2711623003: Update infobars to use VectorIcon struct instead of VectorIconId. (Closed)
Created 3 years, 10 months ago by Evan Stade
Modified 3 years, 10 months ago
Reviewers: sky, Peter Kasting, rohitrao (ping after 24h)
Base URL:
Comments: 12
This is Rietveld
408576698