chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc - Issue 2711563006: Links in generation prompts should go to passwords.google.com.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc

Issue 2711563006: Links in generation prompts should go to passwords.google.com. (Closed)

Patch Set: Added a method in mock Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/ui/passwords/manage_passwords_bubble_model.h » ('j') | chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc

diff --git a/chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc b/chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc

index 524f0165a2b339c9903184a85cd0e6b8d961755a..ebca9f2ccfe00edda2c12b0549b82d316eea36f0 100644

--- a/chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc

+++ b/chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc

@@ -16,7 +16,7 @@

#include "chrome/browser/ui/autofill/password_generation_popup_view.h"

#include "chrome/browser/ui/autofill/popup_constants.h"

#include "chrome/browser/ui/browser_finder.h"

-#include "chrome/browser/ui/chrome_pages.h"

+#include "chrome/browser/ui/browser_navigator_params.h"

#include "chrome/common/url_constants.h"

#include "chrome/grit/chromium_strings.h"

#include "chrome/grit/generated_resources.h"

@@ -24,6 +24,7 @@

#include "components/autofill/core/browser/suggestion.h"

#include "components/password_manager/core/browser/password_bubble_experiment.h"

#include "components/password_manager/core/browser/password_manager.h"

+#include "components/password_manager/core/browser/password_manager_constants.h"

#include "content/public/browser/native_web_keyboard_event.h"

#include "content/public/browser/render_view_host.h"

#include "content/public/browser/web_contents.h"

@@ -225,9 +226,12 @@ void PasswordGenerationPopupControllerImpl::OnSavedPasswordsLinkClicked() {

#if defined(OS_ANDROID)

chrome::android::ChromeApplication::ShowPasswordSettings();

#else

- chrome::ShowSettingsSubPage(

- chrome::FindBrowserWithWebContents(controller_common_.web_contents()),

- chrome::kPasswordManagerSubPage);

+ chrome::NavigateParams params(

+ chrome::FindBrowserWithWebContents(web_contents()),

+ GURL(password_manager::kPasswordManagerAccountDashboardURL),

+ ui::PAGE_TRANSITION_LINK);

+ params.disposition = WindowOpenDisposition::NEW_FOREGROUND_TAB;

+ chrome::Navigate(&params);

#endif

}