Chromium Code Reviews| Index: components/autofill/core/browser/autofill_metrics.h |
| diff --git a/components/autofill/core/browser/autofill_metrics.h b/components/autofill/core/browser/autofill_metrics.h |
| index d849ce143f8bce195815706ee4ac48778b4ad44e..789da6da2085d70f355333dac92cdae9cf434344 100644 |
| --- a/components/autofill/core/browser/autofill_metrics.h |
| +++ b/components/autofill/core/browser/autofill_metrics.h |
| @@ -542,10 +542,20 @@ class AutofillMetrics { |
| // submitted. If the submission is not interrupted by JavaScript, the "form |
| // submitted" event above will also be logged. |
| FORM_EVENT_SUGGESTION_SHOWN_WILL_SUBMIT_ONCE, |
| - |
| NUM_FORM_EVENTS, |
| }; |
| + // Form Events for autofill bank name experiment. |
| + enum BankNameExperimentFormEvent { |
|
Mathieu
2017/06/16 18:27:05
I wouldn't put Experiment in the enum name or desc
Shanfeng
2017/06/16 20:51:46
Done.
|
| + // A dropdown with suggestions was shown and at least one suggestion has a |
| + // bank name. |
| + FORM_EVENT_SUGGESTIONS_SHOWN_WITH_BANK_NAME_AVAILABLE_ONCE = 0, |
| + // A server suggestion was used to fill the form and at least one suggestion |
| + // has a bank name |
| + FORM_EVENT_SERVER_SUGGESTION_FILLED_WITH_BANK_NAME_AVAILABLE_ONCE, |
| + BANK_NAME_NUM_FORM_EVENTS, |
| + }; |
| + |
| // Events related to the Unmask Credit Card Prompt. |
| enum UnmaskPromptEvent { |
| // The prompt was shown. |
| @@ -937,8 +947,10 @@ class AutofillMetrics { |
| void OnFormSubmitted(); |
| + void SetBankNameAvailable(); |
| private: |
| void Log(FormEvent event) const; |
| + void Log(BankNameExperimentFormEvent event) const; |
| bool is_for_credit_card_; |
| size_t server_record_type_count_; |
| @@ -950,6 +962,7 @@ class AutofillMetrics { |
| bool has_logged_suggestion_filled_; |
| bool has_logged_will_submit_; |
| bool has_logged_submitted_; |
| + bool has_logged_bank_name_available_; |
| bool logged_suggestion_filled_was_server_data_; |
| bool logged_suggestion_filled_was_masked_server_card_; |