Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: components/autofill/core/browser/personal_data_manager.cc

Issue 2711543002: Experiment to add bank name in autofill ui. (Closed)
Patch Set: Address comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/personal_data_manager.cc
diff --git a/components/autofill/core/browser/personal_data_manager.cc b/components/autofill/core/browser/personal_data_manager.cc
index 8039bc4e6013783e6b65278799583dedbcbec2c9..1ed3ce545010d2645175c9f3b1298d4ba6687163 100644
--- a/components/autofill/core/browser/personal_data_manager.cc
+++ b/components/autofill/core/browser/personal_data_manager.cc
@@ -1674,7 +1674,12 @@ std::vector<Suggestion> PersonalDataManager::GetSuggestionsForCards(
// Otherwise the label is the card number, or if that is empty the
// cardholder name. The label should never repeat the value.
if (type.GetStorableType() == CREDIT_CARD_NUMBER) {
- suggestion->value = credit_card->NetworkAndLastFourDigits();
+ if (IsAutofillCreditCardBankNameDisplayExperimentEnabled() &&
+ !credit_card->bank_name().empty()) {
+ suggestion->value = credit_card->BankNameAndLastFourDigits();
+ } else {
+ suggestion->value = credit_card->NetworkAndLastFourDigits();
+ }
if (IsAutofillCreditCardLastUsedDateDisplayExperimentEnabled()) {
suggestion->label =
credit_card->GetLastUsedDateForDisplay(app_locale_);

Powered by Google App Engine
This is Rietveld 408576698