Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: components/autofill/core/browser/autofill_metrics.h

Issue 2711543002: Experiment to add bank name in autofill ui. (Closed)
Patch Set: Address comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_metrics.h
diff --git a/components/autofill/core/browser/autofill_metrics.h b/components/autofill/core/browser/autofill_metrics.h
index d849ce143f8bce195815706ee4ac48778b4ad44e..ed5d7074bbe05a2c3fa5ca5dba9c1fb0c9373c7e 100644
--- a/components/autofill/core/browser/autofill_metrics.h
+++ b/components/autofill/core/browser/autofill_metrics.h
@@ -542,10 +542,19 @@ class AutofillMetrics {
// submitted. If the submission is not interrupted by JavaScript, the "form
// submitted" event above will also be logged.
FORM_EVENT_SUGGESTION_SHOWN_WILL_SUBMIT_ONCE,
-
NUM_FORM_EVENTS,
};
+ // Form Events for autofill bank name experiment.
+ enum BankNameExperimentFormEvent {
+ // A dropdown with suggestions was shown and suggestions have bank names.
jiahuiguo 2017/06/14 05:51:28 suggestions shown with bank names?
Shanfeng 2017/06/14 17:48:25 Acknowledged.
+ FORM_EVENT_SUGGESTIONS_SHOWN_WITH_BANK_NAME_AVAILABLE_ONCE = 0,
+ // A server suggestion was used to fill the form and suggestions have bank
Jared Saul 2017/06/14 16:49:15 Alternate: Consider changing "suggestions have ban
Shanfeng 2017/06/14 17:48:25 Done.
+ // names.
+ FORM_EVENT_SERVER_SUGGESTION_FILLED_WITH_BANK_NAME_AVAILABLE_ONCE,
+ BANK_NAME_NUM_FORM_EVENTS,
+ };
+
// Events related to the Unmask Credit Card Prompt.
enum UnmaskPromptEvent {
// The prompt was shown.
@@ -937,8 +946,10 @@ class AutofillMetrics {
void OnFormSubmitted();
+ void SetBankNameAvailable();
private:
void Log(FormEvent event) const;
+ void Log(BankNameExperimentFormEvent event) const;
bool is_for_credit_card_;
size_t server_record_type_count_;
@@ -950,6 +961,7 @@ class AutofillMetrics {
bool has_logged_suggestion_filled_;
bool has_logged_will_submit_;
bool has_logged_submitted_;
+ bool has_logged_bank_name_available_;
bool logged_suggestion_filled_was_server_data_;
bool logged_suggestion_filled_was_masked_server_card_;

Powered by Google App Engine
This is Rietveld 408576698