components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc - Issue 2711543002: Experiment to add bank name in autofill ui.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc

Issue 2711543002: Experiment to add bank name in autofill ui. (Closed)

Patch Set: Fix and add more metrics unit tests Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/core/browser/webdata/autofill_table.cc ('K') | « components/autofill/core/browser/webdata/autofill_table_unittest.cc ('k') | components/test/data/web_database/version_72.sql » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc

diff --git a/components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc b/components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc

index 54e8be78009e5f9a7b64052a29b2c485461628ad..ce8ab456e27dba5fe13e94560580cd9e7b6c8ed9 100644

--- a/components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc

+++ b/components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc

@@ -82,6 +82,9 @@ CreditCard CardFromSpecifics(const sync_pb::WalletMaskedCreditCard& card) {

result.SetExpirationMonth(card.exp_month());

result.SetExpirationYear(card.exp_year());

result.set_billing_address_id(card.billing_address_id());

+ if (card.has_bank_name()) {

sebsg 2017/06/12 21:17:00 remove the if?

Shanfeng 2017/06/12 23:34:58 Done.

+ result.set_bank_name(card.bank_name());

+ }

return result;

}