Chromium Code Reviews| Index: components/autofill/core/browser/personal_data_manager_unittest.cc |
| diff --git a/components/autofill/core/browser/personal_data_manager_unittest.cc b/components/autofill/core/browser/personal_data_manager_unittest.cc |
| index 2a1b23db52fc1c27949428a1859cfb752853c0ec..9d24f8a6016bb421bd1fd5753f1a8ae37591ffde 100644 |
| --- a/components/autofill/core/browser/personal_data_manager_unittest.cc |
| +++ b/components/autofill/core/browser/personal_data_manager_unittest.cc |
| @@ -24,6 +24,7 @@ |
| #include "base/strings/utf_string_conversions.h" |
| #include "base/synchronization/waitable_event.h" |
| #include "base/test/histogram_tester.h" |
| +#include "base/test/scoped_feature_list.h" |
| #include "base/test/simple_test_clock.h" |
| #include "base/threading/thread_task_runner_handle.h" |
| #include "base/time/time.h" |
| @@ -3923,6 +3924,50 @@ TEST_F(PersonalDataManagerTest, |
| ASSERT_EQ(3U, suggestions.size()); |
| } |
| +// Tests that server cards have bank name when feature flag on. |
| +TEST_F(PersonalDataManagerTest, |
| + GetCreditCardSuggestions_ShowBankNameOfServerCards) { |
| + // Turn on feature flag. |
| + base::test::ScopedFeatureList scoped_feature_list_; |
| + scoped_feature_list_.InitAndEnableFeature(kAutofillCreditCardBankNameDisplay); |
| + |
| + EnableWalletCardImport(); |
| + SetupReferenceLocalCreditCards(); |
| + |
| + // Add some server cards. |
| + std::vector<CreditCard> server_cards; |
| + server_cards.push_back(CreditCard(CreditCard::MASKED_SERVER_CARD, "b459")); |
| + test::SetCreditCardInfo(&server_cards.back(), "Emmet Dalton", "2110", "12", |
| + "2999", "1"); |
| + server_cards.back().set_use_count(2); |
| + server_cards.back().set_use_date(AutofillClock::Now() - |
| + base::TimeDelta::FromDays(1)); |
| + server_cards.back().SetNetworkForMaskedCard(kVisaCard); |
| + server_cards.back().SetBankName("Chase"); |
| + |
| + test::SetServerCreditCards(autofill_table_, server_cards); |
| + personal_data_->Refresh(); |
| + EXPECT_CALL(personal_data_observer_, OnPersonalDataChanged()) |
| + .WillOnce(QuitMainMessageLoop()); |
| + base::RunLoop().Run(); |
| + |
| + std::vector<Suggestion> suggestions = |
| + personal_data_->GetCreditCardSuggestions( |
| + AutofillType(CREDIT_CARD_NUMBER), |
| + /* field_contents= */ base::string16()); |
| + ASSERT_EQ(4U, suggestions.size()); |
| + |
| + // All cards should be ordered as expected. |
| + EXPECT_EQ(base::UTF8ToUTF16(std::string("Visa") + kUTF8MidlineEllipsis + "9012"), |
|
Jared Saul
2017/06/07 01:22:59
Looks like these go over 80 chars; wrap?
Shanfeng
2017/06/07 17:20:16
Done.
|
| + suggestions[0].value); |
| + EXPECT_EQ(base::UTF8ToUTF16(std::string("Amex") + kUTF8MidlineEllipsis + "8555"), |
| + suggestions[1].value); |
| + EXPECT_EQ(base::UTF8ToUTF16(std::string("Chase") + kUTF8MidlineEllipsis + "2110"), |
| + suggestions[2].value); |
| + EXPECT_EQ(base::UTF8ToUTF16(std::string("Mastercard") + kUTF8MidlineEllipsis + "2109"), |
| + suggestions[3].value); |
| +} |
| + |
| // Tests that only the full server card is kept when deduping with a local |
| // duplicate of it. |
| TEST_F(PersonalDataManagerTest, |