Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: chrome/browser/about_flags.cc

Issue 2711543002: Experiment to add bank name in autofill ui. (Closed)
Patch Set: Address comments and sync Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index aa20d19c26515fc3eea870732d608bffee6ca69e..8530fca1aaeee52e56aca7522355652d03d7199d 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -2453,12 +2453,15 @@ const FeatureEntry kFeatureEntries[] = {
FEATURE_WITH_PARAMS_VALUE_TYPE(
autofill::kAutofillCreditCardPopupLayout,
kAutofillCreditCardPopupLayoutFeatureVariations,
- "AutofillCreditCardPopupLayout")},
+ // Must be AutofillCreditCardDropdownVariations to prevent DCHECK crash
+ // when the flag is manually enabled in a local build.
+ "AutofillCreditCardDropdownVariations")},
{"native-android-history-manager",
flag_descriptions::kNativeAndroidHistoryManager,
flag_descriptions::kNativeAndroidHistoryManagerDescription, kOsAndroid,
FEATURE_VALUE_TYPE(features::kNativeAndroidHistoryManager)},
#endif // OS_ANDROID
+
{"enable-autofill-credit-card-last-used-date-display",
flag_descriptions::kEnableAutofillCreditCardLastUsedDateDisplay,
flag_descriptions::kEnableAutofillCreditCardLastUsedDateDisplayDescription,
@@ -2466,7 +2469,15 @@ const FeatureEntry kFeatureEntries[] = {
FEATURE_WITH_PARAMS_VALUE_TYPE(
autofill::kAutofillCreditCardLastUsedDateDisplay,
kAutofillCreditCardLastUsedDateFeatureVariations,
- "AutofillCreditCardLastUsedDate")},
+ // Must be AutofillCreditCardDropdownVariations to prevent DCHECK crash
+ // when the flag is manually enabled in a local build.
+ "AutofillCreditCardDropdownVariations")},
+
+ {"enable-autofill-credit-card-bank-name-display",
+ flag_descriptions::kEnableAutofillCreditCardBankNameDisplay,
+ flag_descriptions::kEnableAutofillCreditCardBankNameDisplayDescription,
+ kOsAll, FEATURE_VALUE_TYPE(autofill::kAutofillCreditCardBankNameDisplay)},
+
#if defined(OS_WIN)
{"windows10-custom-titlebar",
flag_descriptions::kWindows10CustomTitlebarName,
« no previous file with comments | « no previous file | chrome/browser/flag_descriptions.h » ('j') | components/autofill/core/browser/credit_card_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698