Experiment to add bank name in autofill ui.

components/webdata/common/web_database_migration_unittest.cc

Index: components/webdata/common/web_database_migration_unittest.cc
diff --git a/components/webdata/common/web_database_migration_unittest.cc b/components/webdata/common/web_database_migration_unittest.cc
index 3229f86ea0e3807efc04547da2b385520d0f6ba9..af9d23d458168298bf92448ebff3c7ac72919ddc 100644
--- a/components/webdata/common/web_database_migration_unittest.cc
+++ b/components/webdata/common/web_database_migration_unittest.cc
@@ -130,7 +130,7 @@ class WebDatabaseMigrationTest : public testing::Test {
   DISALLOW_COPY_AND_ASSIGN(WebDatabaseMigrationTest);
 };
 
-const int WebDatabaseMigrationTest::kCurrentTestedVersionNumber = 71;
+const int WebDatabaseMigrationTest::kCurrentTestedVersionNumber = 72;
 
 void WebDatabaseMigrationTest::LoadDatabase(
     const base::FilePath::StringType& file) {
@@ -1242,3 +1242,66 @@ TEST_F(WebDatabaseMigrationTest, MigrateVersion70ToCurrent) {
     EXPECT_EQ(2050, s_masked_cards.ColumnInt(6));
   }
 }
+
+// Tests addition of bank_name to masked_credit_cards
+TEST_F(WebDatabaseMigrationTest, MigrateVersion71ToCurrent) {
+  ASSERT_NO_FATAL_FAILURE(LoadDatabase(FILE_PATH_LITERAL("version_71.sql")));
+
+  // Verify pre-conditions.
+  {
+    sql::Connection connection;
+    ASSERT_TRUE(connection.Open(GetDatabasePath()));
+    ASSERT_TRUE(sql::MetaTable::DoesTableExist(&connection));
+
+    sql::MetaTable meta_table;
+    ASSERT_TRUE(meta_table.Init(&connection, 71, 71));
+
+    EXPECT_FALSE(connection.DoesColumnExist("masked_credit_cards",
+                                            "bank_name"));
+
+
+    EXPECT_FALSE(connection.DoesColumnExist("masked_credit_cards",
+                                            "billing_address_id"));
+    EXPECT_TRUE(connection.DoesColumnExist("server_card_metadata",
+                                           "billing_address_id"));
+    EXPECT_TRUE(
+        connection.DoesColumnExist("server_address_metadata", "has_converted"));
+  }
+
+  DoMigration();
+
+  // Verify post-conditions.
+  {
+    sql::Connection connection;
+    ASSERT_TRUE(connection.Open(GetDatabasePath()));
+    ASSERT_TRUE(sql::MetaTable::DoesTableExist(&connection));
+
+    // Check version.
+    EXPECT_EQ(kCurrentTestedVersionNumber, VersionFromConnection(&connection));
+
+    // The bank_name column should exist.
+    EXPECT_TRUE(connection.DoesColumnExist("masked_credit_cards", "bank_name"));
+
+    // Make sure that the values in masked_credit_cards are as expected. The
+    // values are added to the table in version_71.sql.
+    sql::Statement s_masked_cards(connection.GetUniqueStatement(
+        "SELECT id, "           // 0
+               "status, "       // 1
+               "name_on_card, " // 2
+               "type, "         // 3
+               "last_four, "    // 4
+               "exp_month, "    // 5
+               "exp_year, "     // 6
+               "bank_name "     // 7
+        "FROM masked_credit_cards"));
+    ASSERT_TRUE(s_masked_cards.Step());
+    EXPECT_EQ("card_1", s_masked_cards.ColumnString(0));
+    EXPECT_EQ("status", s_masked_cards.ColumnString(1));
+    EXPECT_EQ("bob", s_masked_cards.ColumnString(2));
+    EXPECT_EQ("MASKED", s_masked_cards.ColumnString(3));
+    EXPECT_EQ("1234", s_masked_cards.ColumnString(4));
+    EXPECT_EQ(12, s_masked_cards.ColumnInt(5));
+    EXPECT_EQ(2050, s_masked_cards.ColumnInt(6));
+    EXPECT_EQ("", s_masked_cards.ColumnString(7));

[Jared Saul, 2017/03/10 19:51:54]

Can bank name be tested here instead of being ""?

[Shanfeng, 2017/03/10 21:49:57]

This is intended.
This test case is to verify the database migration function works properly. We
don't know the bank name of a card without a downstream sync. So when we add the
bank name column to the table, we couldn't initialize it. That's why the bank
name is empty here.

+  }
+}