Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: components/autofill/core/browser/credit_card.h

Issue 2711543002: Experiment to add bank name in autofill ui. (Closed)
Patch Set: Don't show bank name if bank name is empty even though feature flag on Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/credit_card.h
diff --git a/components/autofill/core/browser/credit_card.h b/components/autofill/core/browser/credit_card.h
index 0fb251e9debe430e9cf9ca1123b2414102c9d37a..c9c4922cf2754b3d05a13ee3a1ee4ba45f82e149 100644
--- a/components/autofill/core/browser/credit_card.h
+++ b/components/autofill/core/browser/credit_card.h
@@ -109,12 +109,19 @@ class CreditCard : public AutofillDataModel {
base::string16 TypeForDisplay() const;
// A label for this credit card formatted as 'Cardname - 2345'.
base::string16 TypeAndLastFourDigits() const;
+ // A lable for this credit card formatted as 'Chase - 2345'.
Jared Saul 2017/02/23 19:23:33 s/lable/label
Shanfeng 2017/02/28 19:22:21 Done.
+ base::string16 BankNameAndLastFourDigits() const;
// Localized expiration for this credit card formatted as 'Exp: 06/17'.
base::string16 AbbreviatedExpirationDateForDisplay() const;
const std::string& type() const { return type_; }
+ const base::string16& bank_name() const { return bank_name_; }
+ void SetBankName(const base::string16& bank_name) {
+ bank_name_ = bank_name;
+ }
+
int expiration_month() const { return expiration_month_; }
int expiration_year() const { return expiration_year_; }
@@ -240,6 +247,9 @@ class CreditCard : public AutofillDataModel {
// The cardholder's name. May be empty.
base::string16 name_on_card_;
+ // The issuer bank name of the card.
+ base::string16 bank_name_;
+
// The type of the card. This is one of the k...Card constants below.
std::string type_;

Powered by Google App Engine
This is Rietveld 408576698