Experiment to add bank name in autofill ui.

components/autofill/core/browser/autofill_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/autofill_manager.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
@@ skipping 1969 matching lines @@
         MakeFrontendID(std::string(), suggestions[i].backend_id);
   }
   return suggestions;
 }
 
 std::vector<Suggestion> AutofillManager::GetCreditCardSuggestions(
     const FormFieldData& field,
     const AutofillType& type) const {
   credit_card_form_event_logger_->OnDidPollSuggestions(field);
 
+  bool isBankNameAvailable = false;
   // The field value is sanitized before attempting to match it to the user's
   // data.
   std::vector<Suggestion> suggestions =
       personal_data_->GetCreditCardSuggestions(
-          type, SanitizeCreditCardFieldValue(field.value));
+          type, SanitizeCreditCardFieldValue(field.value), isBankNameAvailable);

[sebsg, 2017/06/12 21:17:00]

I'm not a fan of setting a value in functions like this. It makes it more
complicated to figure out what the function does. 

Since the work is pretty simple, I propose simply iterating over the cards to
suggest here and checking if on has a bank name.

[Shanfeng, 2017/06/12 23:34:58]

Done.

+  if (isBankNameAvailable) {
+    credit_card_form_event_logger_->SetBankNameAvailable();
+  }
   for (size_t i = 0; i < suggestions.size(); i++) {
     suggestions[i].frontend_id =
         MakeFrontendID(suggestions[i].backend_id, std::string());
     suggestions[i].is_value_bold = IsCreditCardPopupValueBold();
   }
   return suggestions;
 }
 
 void AutofillManager::ParseForms(const std::vector<FormData>& forms) {
   if (forms.empty())
@@ skipping 350 matching lines @@
 #endif  // ENABLE_FORM_DEBUG_DUMP
 
 void AutofillManager::LogCardUploadDecisions(int upload_decision_metrics) {
   AutofillMetrics::LogCardUploadDecisionMetrics(upload_decision_metrics);
   AutofillMetrics::LogCardUploadDecisionsUkm(client_->GetUkmRecorder(),
                                              pending_upload_request_url_,
                                              upload_decision_metrics);
 }
 
 }  // namespace autofill