Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1623)

Side by Side Diff: components/autofill/core/browser/credit_card_unittest.cc

Issue 2711543002: Experiment to add bank name in autofill ui. (Closed)
Patch Set: Address comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 6
7 #include "base/guid.h" 7 #include "base/guid.h"
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/strings/string_number_conversions.h" 9 #include "base/strings/string_number_conversions.h"
10 #include "base/strings/utf_string_conversions.h" 10 #include "base/strings/utf_string_conversions.h"
11 #include "base/test/scoped_feature_list.h"
11 #include "base/time/time.h" 12 #include "base/time/time.h"
12 #include "build/build_config.h" 13 #include "build/build_config.h"
13 #include "components/autofill/core/browser/autofill_experiments.h" 14 #include "components/autofill/core/browser/autofill_experiments.h"
14 #include "components/autofill/core/browser/autofill_test_utils.h" 15 #include "components/autofill/core/browser/autofill_test_utils.h"
15 #include "components/autofill/core/browser/autofill_type.h" 16 #include "components/autofill/core/browser/autofill_type.h"
16 #include "components/autofill/core/browser/credit_card.h" 17 #include "components/autofill/core/browser/credit_card.h"
17 #include "components/autofill/core/browser/validation.h" 18 #include "components/autofill/core/browser/validation.h"
18 #include "components/autofill/core/common/autofill_constants.h" 19 #include "components/autofill/core/common/autofill_constants.h"
19 #include "components/autofill/core/common/form_field_data.h" 20 #include "components/autofill/core/common/form_field_data.h"
20 #include "components/variations/variations_params_manager.h" 21 #include "components/variations/variations_params_manager.h"
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
137 "John Dillinger", 138 "John Dillinger",
138 "0123456789 0123456789 0123456789 5105 1051 0510 5100", "01", "2010"); 139 "0123456789 0123456789 0123456789 5105 1051 0510 5100", "01", "2010");
139 base::string16 summary5 = credit_card5.Label(); 140 base::string16 summary5 = credit_card5.Label();
140 EXPECT_EQ(UTF8ToUTF16("Card" + kUTF8MidlineEllipsis + "5100, 01/2010"), 141 EXPECT_EQ(UTF8ToUTF16("Card" + kUTF8MidlineEllipsis + "5100, 01/2010"),
141 summary5); 142 summary5);
142 base::string16 obfuscated5 = credit_card5.TypeAndLastFourDigits(); 143 base::string16 obfuscated5 = credit_card5.TypeAndLastFourDigits();
143 EXPECT_EQ(UTF8ToUTF16("Card" + kUTF8MidlineEllipsis + "5100"), 144 EXPECT_EQ(UTF8ToUTF16("Card" + kUTF8MidlineEllipsis + "5100"),
144 obfuscated5); 145 obfuscated5);
145 } 146 }
146 147
148 // Tests credit card bank name and last four digits string generation.
149 TEST(CreditCardTest, BankNameAndLastFourDigitsStrings) {
150 // Turn on feature flag.
151 base::test::ScopedFeatureList scoped_feature_list_;
152 scoped_feature_list_.InitAndEnableFeature(kAutofillCreditCardBankNameDisplay);
153
154 // Case 1: Have everything and show bank name
155 CreditCard credit_card1(base::GenerateGUID(), "https://www.example.com/");
156 test::SetCreditCardInfo(
157 &credit_card1, "John Dillinger", "5105 1051 0510 5100", "01", "2010");
158 credit_card1.SetBankName(UTF8ToUTF16("Chase"));
159 base::string16 obfuscated1 = credit_card1.BankNameAndLastFourDigits();
160 EXPECT_FALSE(credit_card1.bank_name().empty());
161 EXPECT_EQ(UTF8ToUTF16("Chase" + kUTF8MidlineEllipsis + "5100"), obfuscated1);
162
163 // Case 2: Have no bank name and not show bank name
164 CreditCard credit_card2(base::GenerateGUID(), "https://www.example.com/");
165 test::SetCreditCardInfo(
166 &credit_card2, "John Dillinger", "5105 1051 0510 5100", "01", "2010");
167 base::string16 obfuscated2 = credit_card2.BankNameAndLastFourDigits();
168 EXPECT_TRUE(credit_card2.bank_name().empty());
169 EXPECT_EQ(UTF8ToUTF16(kUTF8MidlineEllipsis + "5100"), obfuscated2);
Jared Saul 2017/02/28 19:42:23 This is a good case that I missed, but I also mean
170 }
171
147 TEST(CreditCardTest, AssignmentOperator) { 172 TEST(CreditCardTest, AssignmentOperator) {
148 CreditCard a(base::GenerateGUID(), "some origin"); 173 CreditCard a(base::GenerateGUID(), "some origin");
149 test::SetCreditCardInfo(&a, "John Dillinger", "123456789012", "01", "2010"); 174 test::SetCreditCardInfo(&a, "John Dillinger", "123456789012", "01", "2010");
150 175
151 // Result of assignment should be logically equal to the original profile. 176 // Result of assignment should be logically equal to the original profile.
152 CreditCard b(base::GenerateGUID(), "some other origin"); 177 CreditCard b(base::GenerateGUID(), "some other origin");
153 b = a; 178 b = a;
154 EXPECT_TRUE(a == b); 179 EXPECT_TRUE(a == b);
155 180
156 // Assignment to self should not change the profile value. 181 // Assignment to self should not change the profile value.
(...skipping 794 matching lines...) Expand 10 before | Expand all | Expand 10 after
951 credit_card0.GetLastUsedDateForDisplay(test_case.app_locale)); 976 credit_card0.GetLastUsedDateForDisplay(test_case.app_locale));
952 EXPECT_EQ(test_case.last_used_date, 977 EXPECT_EQ(test_case.last_used_date,
953 credit_card1.GetLastUsedDateForDisplay(test_case.app_locale)); 978 credit_card1.GetLastUsedDateForDisplay(test_case.app_locale));
954 EXPECT_EQ(test_case.last_used_year_ago, 979 EXPECT_EQ(test_case.last_used_year_ago,
955 credit_card2.GetLastUsedDateForDisplay(test_case.app_locale)); 980 credit_card2.GetLastUsedDateForDisplay(test_case.app_locale));
956 variation_params_.ClearAllVariationParams(); 981 variation_params_.ClearAllVariationParams();
957 } 982 }
958 } 983 }
959 984
960 } // namespace autofill 985 } // namespace autofill
OLDNEW
« no previous file with comments | « components/autofill/core/browser/credit_card.cc ('k') | components/autofill/core/browser/personal_data_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698