Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: runtime/bin/vmservice/client/lib/src/elements/isolate_view.dart

Issue 271153002: Add pause/resume for isolates in vmservice/observatory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: gen js Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/client/lib/src/elements/isolate_view.dart
diff --git a/runtime/bin/vmservice/client/lib/src/elements/isolate_view.dart b/runtime/bin/vmservice/client/lib/src/elements/isolate_view.dart
index 2c6b121091e26a11796352fae4a00dd835954c0e..582c9eef83c37135ee1941f57813b471cf670327 100644
--- a/runtime/bin/vmservice/client/lib/src/elements/isolate_view.dart
+++ b/runtime/bin/vmservice/client/lib/src/elements/isolate_view.dart
@@ -121,12 +121,21 @@ class IsolateViewElement extends ObservatoryElement {
isolate.reload().whenComplete(done);
}
- void resume(var a, var b, var c) {
- isolate.get("resume").then((result) {
- // TODO(turnidge): Instead of asserting here, handling errors
- // properly.
- assert(result.serviceType == 'Success');
- isolate.reload();
- });
+ Future pause(_) {
+ return isolate.get("debug/pause").then((result) {
+ // TODO(turnidge): Instead of asserting here, handle errors
+ // properly.
+ assert(result.serviceType == 'Success');
+ return isolate.reload();
+ });
+ }
+
+ Future resume(_) {
+ return isolate.get("resume").then((result) {
+ // TODO(turnidge): Instead of asserting here, handle errors
+ // properly.
+ assert(result.serviceType == 'Success');
+ return isolate.reload();
+ });
}
}

Powered by Google App Engine
This is Rietveld 408576698