Add pause/resume for isolates in vmservice/observatory.

runtime/vm/service.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/service.h"
 
 #include "include/dart_api.h"
 #include "platform/globals.h"
 
 #include "vm/compiler.h"
@@ skipping 1371 matching lines @@
   } else if (js->num_arguments() == 2) {
     // Fetch specific script.
     return HandleScriptsFetch(isolate, js);
   } else {
     PrintError(js, "Command too long");
     return true;
   }
 }
 
 
+static bool HandleDebugResume(Isolate* isolate, JSONStream* js) {
+  if (isolate->message_handler()->paused_on_start()) {
+    isolate->message_handler()->set_pause_on_start(false);
+    JSONObject jsobj(js);
+    jsobj.AddProperty("type", "Success");
+    jsobj.AddProperty("id", "");
+    return true;
+  }
+  if (isolate->message_handler()->paused_on_exit()) {
+    isolate->message_handler()->set_pause_on_exit(false);
+    JSONObject jsobj(js);
+    jsobj.AddProperty("type", "Success");
+    jsobj.AddProperty("id", "");
+    return true;
+  }
+  if (isolate->debugger()->PauseEvent() != NULL) {
+    isolate->Resume();
+    JSONObject jsobj(js);
+    jsobj.AddProperty("type", "Success");
+    jsobj.AddProperty("id", "");
+    return true;
+  }
+
+  PrintError(js, "VM was not paused");
+  return true;
+}
+
+
 static bool HandleDebug(Isolate* isolate, JSONStream* js) {
   if (js->num_arguments() == 1) {
     PrintError(js, "Must specify a subcommand");
     return true;
   }
   const char* command = js->GetArgument(1);
   if (strcmp(command, "breakpoints") == 0) {
     if (js->num_arguments() == 2) {
       // Print breakpoint list.
       JSONObject jsobj(js);
@@ skipping 12 matching lines @@
         bpt->PrintJSON(js);
         return true;
       } else {
         PrintError(js, "Unrecognized breakpoint id %s", js->GetArgument(2));
         return true;
       }
     } else {
       PrintError(js, "Command too long");
       return true;
     }
+  } else if (strcmp(command, "pause") == 0) {
+    if (js->num_arguments() == 2) {
+      // TODO(turnidge): Don't double-interrupt the isolate here.
+      isolate->ScheduleInterrupts(Isolate::kApiInterrupt);
+      JSONObject jsobj(js);
+      jsobj.AddProperty("type", "Success");
+      jsobj.AddProperty("id", "");
+      return true;
+    } else {
+      PrintError(js, "Command too long");
+      return true;
+    }
+  } else if (strcmp(command, "resume") == 0) {
+    if (js->num_arguments() == 2) {
+      return HandleDebugResume(isolate, js);
+    } else {
+      PrintError(js, "Command too long");
+      return true;
+    }
   } else {
     PrintError(js, "Unrecognized subcommand '%s'", js->GetArgument(1));
     return true;
   }
 }
 
 
 static bool HandleNullCode(uintptr_t pc, JSONStream* js) {
   // TODO(turnidge): Consider adding/using Object::null_code() for
   // consistent "type".
@@ skipping 132 matching lines @@
     isolate->class_table()->ResetAllocationAccumulators();
   }
   if (should_collect) {
     isolate->heap()->CollectAllGarbage();
   }
   isolate->class_table()->AllocationProfilePrintJSON(js);
   return true;
 }
 
 
-static bool HandleResume(Isolate* isolate, JSONStream* js) {
-  if (isolate->message_handler()->pause_on_start()) {
-    isolate->message_handler()->set_pause_on_start(false);
-    JSONObject jsobj(js);
-    jsobj.AddProperty("type", "Success");
-    jsobj.AddProperty("id", "");
-    return true;
-  }
-  if (isolate->message_handler()->pause_on_exit()) {
-    isolate->message_handler()->set_pause_on_exit(false);
-    JSONObject jsobj(js);
-    jsobj.AddProperty("type", "Success");
-    jsobj.AddProperty("id", "");
-    return true;
-  }
-
-  PrintError(js, "VM was not paused");
-  return true;
-}
-
-
 static bool HandleTypeArguments(Isolate* isolate, JSONStream* js) {
   ObjectStore* object_store = isolate->object_store();
   const Array& table = Array::Handle(object_store->canonical_type_arguments());
   ASSERT(table.Length() > 0);
   TypeArguments& type_args = TypeArguments::Handle();
   const intptr_t table_size = table.Length() - 1;
   const intptr_t table_used = Smi::Value(Smi::RawCast(table.At(table_size)));
   bool only_with_instantiations = false;
   if (js->num_arguments() >= 2) {
     const char* second = js->GetArgument(1);
@@ skipping 114 matching lines @@
   { "address", HandleAddress },
   { "allocationprofile", HandleAllocationProfile },
   { "classes", HandleClasses },
   { "code", HandleCode },
   { "coverage", HandleCoverage },
   { "debug", HandleDebug },
   { "heapmap", HandleHeapMap },
   { "libraries", HandleLibraries },
   { "objects", HandleObjects },
   { "profile", HandleProfile },
-  { "resume", HandleResume },
   { "scripts", HandleScripts },
   { "stacktrace", HandleStackTrace },
   { "typearguments", HandleTypeArguments },
 };
 
 
 static IsolateMessageHandler FindIsolateMessageHandler(const char* command) {
   intptr_t num_message_handlers = sizeof(isolate_handlers) /
                                   sizeof(isolate_handlers[0]);
   for (intptr_t i = 0; i < num_message_handlers; i++) {
@@ skipping 243 matching lines @@
   while (current != NULL) {
     if (strcmp(name, current->name()) == 0) {
       return current;
     }
     current = current->next();
   }
   return NULL;
 }
 
 }  // namespace dart