tools/metrics/histograms/histograms.xml - Issue 2711513005: Remove deprecated and out of date permissions metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 2711513005: Remove deprecated and out of date permissions metrics. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index ab92e9ae51d18804e661d7d5236e003f4f61768a..be00477992af1d7e8790c36798a63a6292c8471a 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -118053,8 +118053,6 @@ value.

<affected-histogram name="ContentSettings.PermissionActionsInsecureOrigin"/>

<affected-histogram name="ContentSettings.PermissionActionsSecureOrigin"/>

<affected-histogram name="Permissions.Action"/>

- <affected-histogram name="Permissions.Action.InsecureOrigin"/>

- <affected-histogram name="Permissions.Action.SecureOrigin"/>

<affected-histogram name="Permissions.Prompt.Accepted.Persisted"/>

<affected-histogram name="Permissions.Prompt.Accepted.PriorDismissCount"/>

<affected-histogram name="Permissions.Prompt.Accepted.PriorIgnoreCount"/>

@@ -118068,6 +118066,16 @@ value.

<affected-histogram name="Permissions.Requested.CrossOrigin"/>

</histogram_suffixes>

+<histogram_suffixes name="PermissionTypesOverInsecureOrigins" separator=".">

+ <suffix name="MidiSysEx" label="Midi SysEx permsision actions"/>

raymes 2017/02/23 05:54:57 I think midi sysex is only available on secure ori

dominickn 2017/02/23 06:11:43 Done.

+ <suffix name="Notifications" label="Notification permission actions"/>

+ <suffix name="ProtectedMedia" label="Protected media permission actions"/>

+ <suffix name="DurableStorage" label="Durable Storage permission actions"/>

raymes 2017/02/23 05:54:57 I think durable storage is only available on secur

dominickn 2017/02/23 06:11:43 Done.

+ <suffix name="Flash" label="Flash permission actions"/>

+ <affected-histogram name="Permissions.Action.InsecureOrigin"/>

+ <affected-histogram name="Permissions.Action.SecureOrigin"/>

+</histogram_suffixes>

<histogram_suffixes name="PersistentMemoryAllocs" separator="."

ordering="prefix,2">