Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: third_party/WebKit/Source/core/svg/SVGGraphicsElement.cpp

Issue 2711503002: Compute a more correct "screen scope" transform for SVGSVGElement (Closed)
Patch Set: Tweak test Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/SVGGraphicsElement.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGGraphicsElement.cpp b/third_party/WebKit/Source/core/svg/SVGGraphicsElement.cpp
index ef6163ef7b2b9d0e1f6ad0e7b482d05612fe6a0b..4e39e7fb80f4d52fdcca3ce067860ca5b333f8d0 100644
--- a/third_party/WebKit/Source/core/svg/SVGGraphicsElement.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGGraphicsElement.cpp
@@ -23,7 +23,9 @@
#include "core/SVGNames.h"
#include "core/dom/StyleChangeReason.h"
+#include "core/frame/FrameView.h"
#include "core/layout/LayoutObject.h"
+#include "core/layout/svg/LayoutSVGRoot.h"
#include "core/svg/SVGElementRareData.h"
#include "core/svg/SVGMatrixTearOff.h"
#include "core/svg/SVGRectTearOff.h"
@@ -71,7 +73,7 @@ AffineTransform SVGGraphicsElement::computeCTM(
break;
ctm = toSVGElement(currentElement)
- ->localCoordinateSpaceTransform(mode)
+ ->localCoordinateSpaceTransform()
.multiply(ctm);
switch (mode) {
@@ -84,7 +86,7 @@ AffineTransform SVGGraphicsElement::computeCTM(
done = currentElement == ancestor;
break;
default:
- ASSERT(mode == ScreenScope);
+ NOTREACHED();
break;
}
}
@@ -99,7 +101,38 @@ AffineTransform SVGGraphicsElement::getCTM(
AffineTransform SVGGraphicsElement::getScreenCTM(
StyleUpdateStrategy styleUpdateStrategy) {
- return computeCTM(ScreenScope, styleUpdateStrategy);
+ if (styleUpdateStrategy == AllowStyleUpdate)
+ document().updateStyleAndLayoutIgnorePendingStylesheets();
+ TransformationMatrix transform;
+ if (LayoutObject* layoutObject = this->layoutObject()) {
+ // Adjust for the zoom level factored into CSS coordinates (WK bug #96361).
+ transform.scale(1.0 / layoutObject->styleRef().effectiveZoom());
+
+ // Origin in the document. (This, together with the inverse-scale above,
+ // performs the same operation as
+ // Document::adjustFloatRectForScrollAndAbsoluteZoom, but in transformation
+ // matrix form.)
+ if (FrameView* view = document().view()) {
+ LayoutRect visibleContentRect(view->visibleContentRect());
+ transform.translate(-visibleContentRect.x(), -visibleContentRect.y());
+ }
+
+ // Apply transforms from our ancestor coordinate space, including any
+ // non-SVG ancestor transforms.
+ transform.multiply(layoutObject->localToAbsoluteTransform());
+
+ // At the SVG/HTML boundary (aka LayoutSVGRoot), we need to apply the
+ // localToBorderBoxTransform to map an element from SVG viewport
+ // coordinates to CSS box coordinates.
+ if (layoutObject->isSVGRoot()) {
+ transform.multiply(
+ toLayoutSVGRoot(layoutObject)->localToBorderBoxTransform());
+ }
+ }
+ // Drop any potential non-affine parts, because we're not able to convey that
+ // information further anyway until getScreenCTM returns a DOMMatrix (4x4
+ // matrix.)
+ return transform.toAffineTransform();
}
SVGMatrixTearOff* SVGGraphicsElement::getCTMFromJavascript() {
« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGGraphicsElement.h ('k') | third_party/WebKit/Source/core/svg/SVGPatternElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698