Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: components/precache/core/proto/precache.proto

Issue 2711473006: Add Precache.Fetch.MinWeight UMA. (Closed)
Patch Set: Track min_weight_fetched in unfinished_work, and add tests. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/precache/core/proto/precache.proto
diff --git a/components/precache/core/proto/precache.proto b/components/precache/core/proto/precache.proto
index dd80621a3b66ac57cf1fa8b1d19ecc0a77fac899..77448c8cade7a33632e3c5c94905c31466ab4d2e 100644
--- a/components/precache/core/proto/precache.proto
+++ b/components/precache/core/proto/precache.proto
@@ -20,6 +20,10 @@ message PrecacheResource {
// How important this resource is for the host. It ranges from 0.0 to 1.0.
// Higher values mean more important.
optional double weight_ratio = 3;
+
+ // How important this resource is for the client; a combination of
+ // weight_ratio and TopHost.visits. Populated only in PrecacheUnfinishedWork.
bengr 2017/02/24 20:58:54 Does this also range from 0.0 to 1.0 with higher v
twifkak 2017/02/25 01:13:40 Done.
+ optional double weight = 4;
jamartin 2017/02/24 21:23:29 This also depends on resource_weight_function, isn
jamartin 2017/02/24 21:23:29 I'm wondering if it makes sense to have distinct w
twifkak 2017/02/25 01:13:39 I don't think that's necessary. resource_weight_fu
twifkak 2017/02/25 01:13:39 Done.
};
message PrecacheManifestId {

Powered by Google App Engine
This is Rietveld 408576698