Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: components/precache/content/precache_manager.cc

Issue 2711473006: Add Precache.Fetch.MinWeight UMA. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/precache/content/precache_manager.cc
diff --git a/components/precache/content/precache_manager.cc b/components/precache/content/precache_manager.cc
index 7732807e8f8e6af204265c69fd075a3f9a0c9bc7..6f64cb9ba9497d13682aba71ed0292f5b66dc6c6 100644
--- a/components/precache/content/precache_manager.cc
+++ b/components/precache/content/precache_manager.cc
@@ -14,6 +14,7 @@
#include "base/memory/ref_counted.h"
#include "base/metrics/field_trial.h"
#include "base/metrics/histogram_macros.h"
+#include "base/optional.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_util.h"
#include "base/time/time.h"
@@ -272,7 +273,7 @@ void PrecacheManager::OnGetUnfinishedWorkDone(
base::TimeDelta::FromHours(6)) {
PrecacheFetcher::RecordCompletionStatistics(
*unfinished_work, unfinished_work->top_host_size(),
- unfinished_work->resource_size());
+ unfinished_work->resource_size(), base::nullopt);
jamartin 2017/02/22 22:54:07 When does this case happen? When we haven't precac
twifkak 2017/02/23 23:28:41 Yes. The problem is that the weights aren't in the
unfinished_work.reset(new PrecacheUnfinishedWork);
}
// If this prefetch is new, set the start time.
« no previous file with comments | « no previous file | components/precache/core/precache_fetcher.h » ('j') | components/precache/core/precache_fetcher.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698