Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 2711403002: Improve fasta scanner performance (Closed)

Created:
3 years, 10 months ago by Dmitry Olshansky
Modified:
3 years, 9 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Improve fasta scanner performance Reorder cases in bigSwitch according to frequency, reduce the number of comparisons. R=ahe@google.com Committed: https://github.com/dart-lang/sdk/commit/8dda473a55e11926c6cb338cace463d7b28fefb0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -86 lines) Patch
M pkg/front_end/lib/src/fasta/scanner/abstract_scanner.dart View 1 chunk +79 lines, -86 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Dmitry Olshansky
3 years, 10 months ago (2017-02-24 17:14:58 UTC) #2
ahe
lgtm Thank you, how much improvement do you see? Initially, I did order them based ...
3 years, 10 months ago (2017-02-25 10:38:32 UTC) #3
Dmitry Olshansky
On 2017/02/25 10:38:32, ahe wrote: > lgtm > > Thank you, how much improvement do ...
3 years, 9 months ago (2017-03-06 10:34:22 UTC) #4
Dmitry Olshansky
On 2017/02/25 10:38:32, ahe wrote: > lgtm > > Thank you, how much improvement do ...
3 years, 9 months ago (2017-03-06 10:34:22 UTC) #5
Dmitry Olshansky
3 years, 9 months ago (2017-03-06 10:35:38 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8dda473a55e11926c6cb338cace463d7b28fefb0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698